linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jeff Layton <jlayton@poochiereds.net>, NeilBrown <neilb@suse.com>,
	Rik van Riel <riel@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	lsf-pc@lists.linux-foundation.org,
	Ric Wheeler <rwheeler@redhat.com>
Subject: Re: [Lsf-pc] [LSF/MM TOPIC] I/O error handling and fsync()
Date: Mon, 23 Jan 2017 11:09:41 +0100	[thread overview]
Message-ID: <20170123100941.GA5745@noname.redhat.com> (raw)
In-Reply-To: <20170123002158.xe7r7us2buc37ybq@thunk.org>

Am 23.01.2017 um 01:21 hat Theodore Ts'o geschrieben:
> On Sun, Jan 22, 2017 at 06:31:57PM -0500, Jeff Layton wrote:
> > 
> > Ahh, sorry if I wasn't clear.
> > 
> > I know Kevin posed this topic in the context of QEMU/KVM, and I figure
> > that running virt guests (themselves doing all sorts of workloads) is a
> > pretty common setup these days. That was what I meant by "use case"
> > here. Obviously there are many other workloads that could benefit from
> > (or be harmed by) changes in this area.
> > 
> > Still, I think that looking at QEMU/KVM as a "application" and
> > considering what we can do to help optimize that case could be helpful
> > here (and might also be helpful for other workloads).
> 
> Well, except for QEMU/KVM, Kevin has already confirmed that using
> Direct I/O is a completely viable solution.  (And I'll add it solves a
> bunch of other problems, including page cache efficiency....)

Yes, "don't ever use non-O_DIRECT in production" is probably workable as
a solution to the "state after failed fsync()" problem, as long as it is
consistently implemented throughout the stack. That is, if we use a
network protocol in QEMU (NFS, gluster, etc.), the server needs to use
O_DIRECT, too, if we don't want to get the same problem one level down
the stack. I'm not sure if that's possible with all of them, but if it
is, it's mostly just a matter of configuring them correctly.

However, if we look at the greater problem of hanging requests that came
up in the more recent emails of this thread, it is only moved rather
than solved. Chances are that already write() would hang now instead of
only fsync(), but we still have a hard time dealing with this.

Kevin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-01-23 10:09 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 16:02 [LSF/MM TOPIC] I/O error handling and fsync() Kevin Wolf
2017-01-11  0:41 ` NeilBrown
2017-01-13 11:09   ` Kevin Wolf
2017-01-13 14:21     ` Theodore Ts'o
2017-01-13 16:00       ` Kevin Wolf
2017-01-13 22:28         ` NeilBrown
2017-01-14  6:18           ` Darrick J. Wong
2017-01-16 12:14           ` [Lsf-pc] " Jeff Layton
2017-01-22 22:44             ` NeilBrown
2017-01-22 23:31               ` Jeff Layton
2017-01-23  0:21                 ` Theodore Ts'o
2017-01-23 10:09                   ` Kevin Wolf [this message]
2017-01-23 12:10                     ` Jeff Layton
2017-01-23 17:25                       ` Theodore Ts'o
2017-01-23 17:53                         ` Chuck Lever
2017-01-23 22:40                         ` Jeff Layton
2017-01-23 22:35                     ` Jeff Layton
2017-01-23 23:09                       ` Trond Myklebust
2017-01-24  0:16                         ` NeilBrown
2017-01-24  0:46                           ` Jeff Layton
2017-01-24 21:58                             ` NeilBrown
2017-01-25 13:00                               ` Jeff Layton
2017-01-30  5:30                                 ` NeilBrown
2017-01-24  3:34                           ` Trond Myklebust
2017-01-25 18:35                             ` Theodore Ts'o
2017-01-26  0:36                               ` NeilBrown
2017-01-26  9:25                                 ` Jan Kara
2017-01-26 22:19                                   ` NeilBrown
2017-01-27  3:23                                     ` Theodore Ts'o
2017-01-27  6:03                                       ` NeilBrown
2017-01-30 16:04                                       ` Jan Kara
2017-01-13 18:40     ` Al Viro
2017-01-13 19:06       ` Kevin Wolf
2017-01-11  5:03 ` Theodore Ts'o
2017-01-11  9:47   ` [Lsf-pc] " Jan Kara
2017-01-11 15:45     ` Theodore Ts'o
2017-01-11 10:55   ` Chris Vest
2017-01-11 11:40   ` Kevin Wolf
2017-01-13  4:51     ` NeilBrown
2017-01-13 11:51       ` Kevin Wolf
2017-01-13 21:55         ` NeilBrown
2017-01-11 12:14   ` Chris Vest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123100941.GA5745@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=hch@infradead.org \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lsf-pc@lists.linux-foundation.org \
    --cc=neilb@suse.com \
    --cc=riel@redhat.com \
    --cc=rwheeler@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).