linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrea Arcangeli <aarcange@redhat.com>,
	Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv3 00/12] Fix few rmap-related THP bugs
Date: Sun, 29 Jan 2017 20:38:46 +0300	[thread overview]
Message-ID: <20170129173858.45174-1-kirill.shutemov@linux.intel.com> (raw)

The patch fixes handing PTE-mapped THPs in page_referenced() and
page_idle_clear_pte_refs().

To achieve that I've intrdocued new helper -- page_vma_mapped_walk() -- which
replaces all page_check_address{,_transhuge}() and covers all THP cases.

Patchset overview:
  - First patch fixes one uprobe bug (unrelated to the rest of the
    patchset, just spotted it at the same time);

  - Patches 2-5 fix handling PTE-mapped THPs in page_referenced(),
    page_idle_clear_pte_refs() and rmap core;

  - Patches 6-12 convert all page_check_address{,_transhuge}() users (plus
    remove_migration_pte()) to page_vma_mapped_walk() and drop unused helpers.

I think the fixes are not critical enough for stable@ as they don't lead
to crashes or hangs, only suboptimal behaviour.

Please review and consider applying.

v3:
  - fix page_vma_mapped_walk() breakage;
  - fix one more build error reported by 0-day testing;
  - Add few Acked-by/Reviewed-by;
v2:
  - address feedback from Andrew;
  - fix build errors noticed by 0-day testing.

Kirill A. Shutemov (12):
  uprobes: split THPs before trying replace them
  mm: introduce page_vma_mapped_walk()
  mm: fix handling PTE-mapped THPs in page_referenced()
  mm: fix handling PTE-mapped THPs in page_idle_clear_pte_refs()
  mm, rmap: check all VMAs that PTE-mapped THP can be part of
  mm: convert page_mkclean_one() to use page_vma_mapped_walk()
  mm: convert try_to_unmap_one() to use page_vma_mapped_walk()
  mm, ksm: convert write_protect_page() to use page_vma_mapped_walk()
  mm, uprobes: convert __replace_page() to use page_vma_mapped_walk()
  mm: convert page_mapped_in_vma() to use page_vma_mapped_walk()
  mm: drop page_check_address{,_transhuge}
  mm: convert remove_migration_pte() to use page_vma_mapped_walk()

 include/linux/rmap.h    |  52 ++---
 kernel/events/uprobes.c |  26 ++-
 mm/Makefile             |   6 +-
 mm/huge_memory.c        |  25 +--
 mm/internal.h           |   9 +-
 mm/ksm.c                |  34 +--
 mm/migrate.c            | 104 ++++-----
 mm/page_idle.c          |  34 +--
 mm/page_vma_mapped.c    | 218 ++++++++++++++++++
 mm/rmap.c               | 574 +++++++++++++++++++-----------------------------
 10 files changed, 573 insertions(+), 509 deletions(-)
 create mode 100644 mm/page_vma_mapped.c

-- 
2.11.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2017-01-29 17:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-29 17:38 Kirill A. Shutemov [this message]
2017-01-29 17:38 ` [PATCHv3 01/12] uprobes: split THPs before trying replace them Kirill A. Shutemov
2017-01-31 15:44   ` Oleg Nesterov
2017-01-29 17:38 ` [PATCHv3 02/12] mm: introduce page_vma_mapped_walk() Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 03/12] mm: fix handling PTE-mapped THPs in page_referenced() Kirill A. Shutemov
2017-02-02 15:26   ` Michal Hocko
2017-02-04 10:33     ` Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 04/12] mm: fix handling PTE-mapped THPs in page_idle_clear_pte_refs() Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 05/12] mm, rmap: check all VMAs that PTE-mapped THP can be part of Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 06/12] mm: convert page_mkclean_one() to use page_vma_mapped_walk() Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 07/12] mm: convert try_to_unmap_one() " Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 08/12] mm, ksm: convert write_protect_page() " Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 09/12] mm, uprobes: convert __replace_page() " Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 10/12] mm: convert page_mapped_in_vma() " Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 11/12] mm: drop page_check_address{,_transhuge} Kirill A. Shutemov
2017-01-29 17:38 ` [PATCHv3 12/12] mm: convert remove_migration_pte() to use page_vma_mapped_walk() Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170129173858.45174-1-kirill.shutemov@linux.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).