From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 02C496B0278 for ; Mon, 30 Jan 2017 11:38:51 -0500 (EST) Received: by mail-wm0-f69.google.com with SMTP id v77so69509528wmv.5 for ; Mon, 30 Jan 2017 08:38:50 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id w48si17152879wrc.70.2017.01.30.08.38.49 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 30 Jan 2017 08:38:49 -0800 (PST) Date: Mon, 30 Jan 2017 17:38:47 +0100 From: Michal Hocko Subject: Re: [PATCH v4 2/2] HWPOISON: soft offlining for non-lru movable page Message-ID: <20170130163846.GD4664@dhcp22.suse.cz> References: <1485356738-4831-1-git-send-email-ysxie@foxmail.com> <1485356738-4831-3-git-send-email-ysxie@foxmail.com> <20170126092725.GD6590@dhcp22.suse.cz> <588F55ED.3010509@foxmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <588F55ED.3010509@foxmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Yisheng Xie Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com, qiuxishi@huawei.com On Mon 30-01-17 23:04:13, Yisheng Xie wrote: > Hi, Michal, > Sorry for late reply. > > On 01/26/2017 05:27 PM, Michal Hocko wrote: > > On Wed 25-01-17 23:05:38, ysxie@foxmail.com wrote: > >> From: Yisheng Xie > >> > >> This patch is to extends soft offlining framework to support > >> non-lru page, which already support migration after > >> commit bda807d44454 ("mm: migrate: support non-lru movable page > >> migration") > >> > >> When memory corrected errors occur on a non-lru movable page, > >> we can choose to stop using it by migrating data onto another > >> page and disable the original (maybe half-broken) one. > >> > >> Signed-off-by: Yisheng Xie > >> Suggested-by: Michal Hocko > >> Suggested-by: Minchan Kim > >> Reviewed-by: Minchan Kim > >> Acked-by: Naoya Horiguchi > >> CC: Vlastimil Babka > >> --- > >> mm/memory-failure.c | 26 ++++++++++++++++---------- > >> 1 file changed, 16 insertions(+), 10 deletions(-) > >> > >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c > >> index f283c7e..56e39f8 100644 > >> --- a/mm/memory-failure.c > >> +++ b/mm/memory-failure.c > >> @@ -1527,7 +1527,8 @@ static int get_any_page(struct page *page, unsigned long pfn, int flags) > >> { > >> int ret = __get_any_page(page, pfn, flags); > >> > >> - if (ret == 1 && !PageHuge(page) && !PageLRU(page)) { > >> + if (ret == 1 && !PageHuge(page) && > >> + !PageLRU(page) && !__PageMovable(page)) { > >> /* > >> * Try to free it. > >> */ > > Is this sufficient? Not that I am familiar with get_any_page() but > > __get_any_page doesn't seem to be aware of movable pages and neither > > shake_page is. > Sorry,maybe I do not quite get what you mean. > If the page can be migrated, it can skip "shake_page and __get_any_page once more" here, > though it is not a free page. right ? > Please let me know if I miss anything. No, you are right, it is me who read the code incorrectly. Sorry about the confusion. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org