From: Jerome Glisse <jglisse@redhat.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, vbabka@suse.cz, mgorman@suse.de,
minchan@kernel.org, aneesh.kumar@linux.vnet.ibm.com,
bsingharora@gmail.com, srikar@linux.vnet.ibm.com,
haren@linux.vnet.ibm.com, dave.hansen@intel.com,
dan.j.williams@intel.com
Subject: Re: [RFC V2 00/12] Define coherent device memory node
Date: Tue, 31 Jan 2017 01:15:23 -0500 [thread overview]
Message-ID: <20170131061522.GA2470@redhat.com> (raw)
In-Reply-To: <1e57493b-1981-7c36-612d-3ddaf6ca88b7@linux.vnet.ibm.com>
On Tue, Jan 31, 2017 at 11:18:49AM +0530, Anshuman Khandual wrote:
> Hello Dave/Jerome/Mel,
>
> Here is the overall layout of the functions I am trying to put together
> through this patch series.
>
> (1) Define CDM from core VM and kernel perspective
>
> (2) Isolation/Special consideration for HugeTLB allocations
>
> (3) Isolation/Special consideration for buddy allocations
>
> (a) Zonelist modification based isolation (proposed)
> (b) Cpuset modification based isolation (proposed)
> (c) Buddy modification based isolation (working)
>
> (4) Define VMA containing CDM memory with a new flag VM_CDM
>
> (5) Special consideration for VM_CDM marked VMAs
>
> (a) Special consideration for auto NUMA
> (b) Special consideration for KSM
I believe (5) should not be done on per vma basis but on a page basis.
Thus rendering (4) pointless. A vma shouldn't be special because it has
some special kind of memory irespective of what the vma points to.
> Is there are any other area which needs to be taken care of before CDM
> node can be represented completely inside the kernel ?
Maybe thing like swap or suspend and resume (i know you are targetting big
computer and not laptop :)) but you can't presume what platform CDM might
be use latter on.
Also userspace might be confuse by looking a /proc/meminfo or any of the
sysfs file and see all this device memory without understanding that it
is special and might be unwise to be use for regular CPU only task.
I would probably want CDM memory be reported separatly from the rest of
memory. Which also most likely have repercution with memory cgroup.
My expectation is that you only want to use device memory in a process
if and only if that process also use the device to some extent. So
having new group hierarchy for this memory is probably a better path
forward.
Cheers,
Jerome
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-01-31 6:15 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 3:35 [RFC V2 00/12] Define coherent device memory node Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 01/12] mm: Define coherent device memory (CDM) node Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 02/12] mm: Isolate HugeTLB allocations away from CDM nodes Anshuman Khandual
2017-01-30 17:19 ` Dave Hansen
2017-01-31 1:03 ` Anshuman Khandual
2017-01-31 1:37 ` Dave Hansen
2017-02-01 13:59 ` Anshuman Khandual
2017-02-01 19:01 ` Dave Hansen
2017-01-30 3:35 ` [RFC V2 03/12] mm: Change generic FALLBACK zonelist creation process Anshuman Khandual
2017-01-30 17:34 ` Dave Hansen
2017-01-31 1:36 ` Anshuman Khandual
2017-01-31 1:57 ` Dave Hansen
2017-01-31 7:25 ` John Hubbard
2017-01-31 18:04 ` Dave Hansen
2017-01-31 19:14 ` David Nellans
2017-02-01 6:56 ` Anshuman Khandual
2017-02-01 6:46 ` Anshuman Khandual
2017-02-01 6:40 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 04/12] mm: Change mbind(MPOL_BIND) implementation for CDM nodes Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init() Anshuman Khandual
2017-01-30 17:36 ` Dave Hansen
2017-01-30 20:30 ` Mel Gorman
2017-01-31 14:22 ` [RFC] cpuset: Enable changing of top_cpuset's mems_allowed nodemask Anshuman Khandual
2017-01-31 16:00 ` Mel Gorman
2017-02-01 7:31 ` Anshuman Khandual
2017-02-01 8:53 ` Michal Hocko
2017-02-01 9:18 ` Mel Gorman
2017-01-31 14:36 ` [RFC V2 05/12] cpuset: Add cpuset_inc() inside cpuset_init() Vlastimil Babka
2017-01-31 15:30 ` Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 06/12] mm: Exclude CDM nodes from task->mems_allowed and root cpuset Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 07/12] mm: Ignore cpuset enforcement when allocation flag has __GFP_THISNODE Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 08/12] mm: Add new VMA flag VM_CDM Anshuman Khandual
2017-01-30 18:52 ` Jerome Glisse
2017-01-31 4:22 ` Anshuman Khandual
2017-01-31 6:05 ` Jerome Glisse
2017-01-30 3:35 ` [RFC V2 09/12] mm: Exclude CDM marked VMAs from auto NUMA Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 10/12] mm: Ignore madvise(MADV_MERGEABLE) request for VM_CDM marked VMAs Anshuman Khandual
2017-01-30 3:35 ` [RFC V2 11/12] mm: Tag VMA with VM_CDM flag during page fault Anshuman Khandual
2017-01-30 17:51 ` Dave Hansen
2017-01-31 5:10 ` Anshuman Khandual
2017-01-31 17:54 ` Dave Hansen
2017-01-30 3:35 ` [RFC V2 12/12] mm: Tag VMA with VM_CDM flag explicitly during mbind(MPOL_BIND) Anshuman Khandual
2017-01-30 17:54 ` Dave Hansen
2017-01-31 4:36 ` Anshuman Khandual
2017-02-07 18:07 ` Dave Hansen
2017-02-08 14:13 ` Anshuman Khandual
2017-02-08 15:04 ` Jerome Glisse
2017-01-30 3:35 ` [DEBUG 13/21] powerpc/mm: Identify coherent device memory nodes during platform init Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 14/21] powerpc/mm: Create numa nodes for hotplug memory Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 15/21] powerpc/mm: Enable CONFIG_MOVABLE_NODE for PPC64 platform Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 16/21] mm: Enable CONFIG_MOVABLE_NODE on powerpc Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 17/21] mm: Export definition of 'zone_names' array through mmzone.h Anshuman Khandual
2017-01-30 3:35 ` [DEBUG 18/21] mm: Add debugfs interface to dump each node's zonelist information Anshuman Khandual
2017-01-30 3:36 ` [DEBUG 19/21] mm: Add migrate_virtual_range migration interface Anshuman Khandual
2017-01-30 3:36 ` [DEBUG 20/21] drivers: Add two drivers for coherent device memory tests Anshuman Khandual
2017-01-30 3:36 ` [DEBUG 21/21] selftests/powerpc: Add a script to perform random VMA migrations Anshuman Khandual
2017-01-31 5:48 ` [RFC V2 00/12] Define coherent device memory node Anshuman Khandual
2017-01-31 6:15 ` Jerome Glisse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131061522.GA2470@redhat.com \
--to=jglisse@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=haren@linux.vnet.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).