From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f197.google.com (mail-qt0-f197.google.com [209.85.216.197]) by kanga.kvack.org (Postfix) with ESMTP id 23C216B0033 for ; Wed, 1 Feb 2017 22:51:23 -0500 (EST) Received: by mail-qt0-f197.google.com with SMTP id k15so6747445qtg.5 for ; Wed, 01 Feb 2017 19:51:23 -0800 (PST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com. [66.111.4.25]) by mx.google.com with ESMTPS id w62si15951573qkb.124.2017.02.01.19.51.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2017 19:51:22 -0800 (PST) Date: Thu, 2 Feb 2017 14:51:17 +1100 From: Tobin Harding Subject: Re: [PATCH 2/4] mm: Fix checkpatch warnings, whitespace Message-ID: <20170202035117.GA15650@eros> References: <1485992240-10986-1-git-send-email-me@tobin.cc> <1485992240-10986-3-git-send-email-me@tobin.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , "Kirill A. Shutemov" , Jan Kara , Ross Zwisler , Michal Hocko On Wed, Feb 01, 2017 at 04:48:28PM -0800, David Rientjes wrote: > On Thu, 2 Feb 2017, Tobin C. Harding wrote: > > > @@ -3696,8 +3695,8 @@ int handle_mm_fault(struct vm_area_struct *vma, unsigned long address, > > * VM_FAULT_OOM), there is no need to kill anything. > > * Just clean up the OOM state peacefully. > > */ > > - if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM)) > > - mem_cgroup_oom_synchronize(false); > > + if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM)) > > + mem_cgroup_oom_synchronize(false); > > } > > > > /* > > The comment suffers from the same problem. The comment is fixed in the next patch of the set. The fixes are in separate patches because one was a checkpatch warning and one was an error. Any comments on the structure of the patchset most appreciated. thanks, Tobin. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org