From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Yisheng Xie <xieyisheng1@huawei.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com,
ngupta@vflare.org, guohanjun@huawei.com
Subject: Re: [PATCH v2] mm/zsmalloc: fix comment in zsmalloc
Date: Thu, 9 Feb 2017 17:09:17 +0900 [thread overview]
Message-ID: <20170209080917.GA23016@bbox> (raw)
In-Reply-To: <20170209070543.GA9995@jagdpanzerIV.localdomain>
On Thu, Feb 09, 2017 at 04:05:43PM +0900, Sergey Senozhatsky wrote:
> On (02/09/17 14:13), Yisheng Xie wrote:
> > The class index and fullness group are not encoded in (first)page->mapping
> > any more, after commit 3783689a1aa8 ("zsmalloc: introduce zspage
> > structure"). Instead, they are store in struct zspage. Just delete this
> > unneeded comment.
> >
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Cc: Minchan Kim <minchan@kernel.org>
> > Cc: Nitin Gupta <ngupta@vflare.org>
> > Cc: Hanjun Guo <guohanjun@huawei.com>
Acked-by: Minchan Kim <minchan@kernel.org>
> > ---
> > v2:
> > * just delete the comment for it is no need anymore, suggested by Sergey.
>
> thanks for the patch.
>
> my "suggestion" was just a side note, nothing more. I'm fine with the
> "fix the comment" patch that Andrew has added to mmotm.
> we need Minchan's opinion on this, until he speaks out let's have V1
> ("fix the comment") applied.
I agree on Sergey's opinion.
Andrew,
Please drop previous patch and replace it with this.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-02-09 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 6:13 [PATCH v2] mm/zsmalloc: fix comment in zsmalloc Yisheng Xie
2017-02-09 7:05 ` Sergey Senozhatsky
2017-02-09 8:09 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209080917.GA23016@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).