From: Oleg Nesterov <oleg@redhat.com>
To: Aleksa Sarai <asarai@suse.de>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cyphar@cyphar.com
Subject: Re: [PATCH] oom_reaper: switch to struct list_head for reap queue
Date: Tue, 14 Feb 2017 18:37:17 +0100 [thread overview]
Message-ID: <20170214173717.GA8913@redhat.com> (raw)
In-Reply-To: <e876e49b-8b65-d827-af7d-cbf8aef97585@suse.de>
On 02/15, Aleksa Sarai wrote:
>
> >This is an extra pointer to task_struct and more lines of code to
> >accomplish the same thing. Why would we want to do that?
>
> I don't think it's more "actual" lines of code (I think the wrapping is
> inflating the line number count),
I too think it doesn't make sense to blow task_struct and the generated code.
And to me this patch doesn't make the source code more clean.
> but switching it means that it's more in
> line with other queues in the kernel (it took me a bit to figure out what
> was going on with oom_reaper_list beforehand).
perhaps you can turn oom_reaper_list into llist_head then. This will also
allow to remove oom_reaper_lock. Not sure this makes sense too.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-02-14 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 15:07 [PATCH] oom_reaper: switch to struct list_head for reap queue Aleksa Sarai
2017-02-14 16:30 ` Johannes Weiner
2017-02-14 16:52 ` Aleksa Sarai
2017-02-14 17:37 ` Oleg Nesterov [this message]
2017-02-15 9:01 ` Aleksa Sarai
2017-02-20 15:53 ` Michal Hocko
2017-02-15 8:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214173717.GA8913@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=asarai@suse.de \
--cc=cyphar@cyphar.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).