From: Michal Hocko <mhocko@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Brian Foster <bfoster@redhat.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Xiong Zhou <xzhou@redhat.com>,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, Michal Hocko <mhocko@suse.com>
Subject: [PATCH 2/2] xfs: back off from kmem_zalloc_greedy if the task is killed
Date: Thu, 2 Mar 2017 16:45:41 +0100 [thread overview]
Message-ID: <20170302154541.16155-2-mhocko@kernel.org> (raw)
In-Reply-To: <20170302154541.16155-1-mhocko@kernel.org>
From: Michal Hocko <mhocko@suse.com>
It doesn't really make much sense to retry vmalloc request if the
current task is killed. We should rather bail out as soon as possible
and let it RIP as soon as possible. The current implementation of
vmalloc will fail anyway.
Suggested-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
fs/xfs/kmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c
index ee95f5c6db45..01c52567a4ff 100644
--- a/fs/xfs/kmem.c
+++ b/fs/xfs/kmem.c
@@ -34,7 +34,7 @@ kmem_zalloc_greedy(size_t *size, size_t minsize, size_t maxsize)
size_t kmsize = maxsize;
while (!(ptr = vzalloc(kmsize))) {
- if (kmsize == minsize)
+ if (kmsize == minsize || fatal_signal_pending(current))
break;
if ((kmsize >>= 1) <= minsize)
kmsize = minsize;
--
2.11.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-02 15:45 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 4:46 mm allocation failure and hang when running xfstests generic/269 on xfs Xiong Zhou
2017-03-02 0:37 ` Christoph Hellwig
2017-03-02 5:19 ` Xiong Zhou
2017-03-02 6:41 ` Bob Liu
2017-03-02 6:47 ` Anshuman Khandual
2017-03-02 8:42 ` Michal Hocko
2017-03-02 9:23 ` Xiong Zhou
2017-03-02 10:04 ` Tetsuo Handa
2017-03-02 10:35 ` Michal Hocko
2017-03-02 10:53 ` mm allocation failure and hang when running xfstests generic/269on xfs Tetsuo Handa
2017-03-02 12:24 ` mm allocation failure and hang when running xfstests generic/269 on xfs Brian Foster
2017-03-02 12:49 ` Michal Hocko
2017-03-02 13:00 ` Brian Foster
2017-03-02 13:07 ` Tetsuo Handa
2017-03-02 13:27 ` Michal Hocko
2017-03-02 13:41 ` Brian Foster
2017-03-02 13:50 ` Michal Hocko
2017-03-02 14:23 ` Brian Foster
2017-03-02 14:34 ` Michal Hocko
2017-03-02 14:51 ` Brian Foster
2017-03-02 15:14 ` Michal Hocko
2017-03-02 15:30 ` Brian Foster
2017-03-02 15:45 ` [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Michal Hocko
2017-03-02 15:45 ` Michal Hocko [this message]
2017-03-02 15:49 ` [PATCH 2/2] xfs: back off from kmem_zalloc_greedy if the task is killed Christoph Hellwig
2017-03-02 15:59 ` Brian Foster
2017-03-02 15:49 ` [PATCH 1/2] xfs: allow kmem_zalloc_greedy to fail Christoph Hellwig
2017-03-02 15:59 ` Brian Foster
2017-03-02 16:16 ` Michal Hocko
2017-03-02 16:44 ` Darrick J. Wong
2017-03-03 22:54 ` Dave Chinner
2017-03-03 23:19 ` Darrick J. Wong
2017-03-04 4:48 ` Dave Chinner
2017-03-06 13:21 ` Michal Hocko
2017-03-02 15:47 ` mm allocation failure and hang when running xfstests generic/269 on xfs Michal Hocko
2017-03-02 15:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302154541.16155-2-mhocko@kernel.org \
--to=mhocko@kernel.org \
--cc=bfoster@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).