Re: [RFC 01/11] mm: use SWAP_SUCCESS instead of 0

Anshuman Khandual
2017-03-02T14:27:19Z

On 03/02/2017 12:09 PM, Minchan Kim wrote:
> SWAP_SUCCESS defined value 0 can be changed always so don't rely on
> it. Instead, use explict macro.

Right. But should not we move the changes to the callers last in the
patch series after doing the cleanup to the try_to_unmap() function
as intended first.

> > Cc: Kirill A. Shutemov <kirill@shutemov.name>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> ---
> mm/huge_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 092cc5c..fe2ccd4 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -2114,7 +2114,7 @@ static void freeze_page(struct page *page)
> ttu_flags |= TTU_MIGRATION;
>
> ret = try_to_unmap(page, ttu_flags);
> - VM_BUG_ON_PAGE(ret, page);
> + VM_BUG_ON_PAGE(ret != SWAP_SUCCESS, page);
> }
>
> static void unfreeze_page(struct page *page)