From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id 8485F6B0395 for ; Mon, 13 Mar 2017 18:30:24 -0400 (EDT) Received: by mail-pg0-f69.google.com with SMTP id y17so327722650pgh.2 for ; Mon, 13 Mar 2017 15:30:24 -0700 (PDT) Date: Mon, 13 Mar 2017 15:27:58 -0700 From: Matthew Wilcox Subject: Re: [RFC PATCH 11/13] mm/vas: Introduce VAS segments - shareable address space regions Message-ID: <20170313222758.GB4033@bombadil.infradead.org> References: <20170313221415.9375-1-till.smejkal@gmail.com> <20170313221415.9375-12-till.smejkal@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170313221415.9375-12-till.smejkal@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Till Smejkal Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Steven Miao , Richard Kuo , Tony Luck , Fenghua Yu , James Hogan , Ralf Baechle , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Yoshinori Sato , Rich Felker , "David S. Miller" , Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Andy Lutomirski , Chris Zankel , Max Filippov , Arnd Bergmann , Greg Kroah-Hartman , Laurent Pinchart , Mauro Carvalho Chehab , Pawel Osciak , Marek Szyprowski , Kyungmin Park , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Felipe Balbi , Alexander Viro , Benjamin LaHaise , Nadia Yvette Chambers , Jeff Layton , "J. Bruce Fields" , Peter Zijlstra , Hugh Dickins , Arnaldo Carvalho de Melo , Alexander Shishkin , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-mm@kvack.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, alsa-devel@alsa-project.org On Mon, Mar 13, 2017 at 03:14:13PM -0700, Till Smejkal wrote: > +/** > + * Create a new VAS segment. > + * > + * @param[in] name: The name of the new VAS segment. > + * @param[in] start: The address where the VAS segment begins. > + * @param[in] end: The address where the VAS segment ends. > + * @param[in] mode: The access rights for the VAS segment. > + * > + * @returns: The VAS segment ID on success, -ERRNO otherwise. > + **/ Please follow the kernel-doc conventions, as described in Documentation/doc-guide/kernel-doc.rst. Also, function documentation goes with the implementation, not the declaration. > +/** > + * Get ID of the VAS segment belonging to a given name. > + * > + * @param[in] name: The name of the VAS segment for which the ID > + * should be returned. > + * > + * @returns: The VAS segment ID on success, -ERRNO > + * otherwise. > + **/ > +extern int vas_seg_find(const char *name); So ... segments have names, and IDs ... and access permissions ... Why isn't this a special purpose filesystem? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org