From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id C3A9B6B0388 for ; Thu, 16 Mar 2017 01:44:35 -0400 (EDT) Received: by mail-pg0-f69.google.com with SMTP id b2so72995015pgc.6 for ; Wed, 15 Mar 2017 22:44:35 -0700 (PDT) Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com. [2607:f8b0:400e:c05::243]) by mx.google.com with ESMTPS id c32si4205347plj.141.2017.03.15.22.44.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Mar 2017 22:44:35 -0700 (PDT) Received: by mail-pg0-x243.google.com with SMTP id y17so4756731pgh.0 for ; Wed, 15 Mar 2017 22:44:35 -0700 (PDT) Date: Thu, 16 Mar 2017 14:44:30 +0900 From: Sergey Senozhatsky Subject: Re: [PATCH v2 10/10] mm: remove SWAP_[SUCCESS|AGAIN|FAIL] Message-ID: <20170316054430.GA464@jagdpanzerIV.localdomain> References: <1489555493-14659-1-git-send-email-minchan@kernel.org> <1489555493-14659-11-git-send-email-minchan@kernel.org> <20170316044023.GA2597@jagdpanzerIV.localdomain> <20170316053313.GA19241@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170316053313.GA19241@bbox> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@lge.com, Johannes Weiner , Michal Hocko , "Kirill A. Shutemov" , Anshuman Khandual On (03/16/17 14:33), Minchan Kim wrote: [..] > "There is no user for it" > > I was liar so need to be a honest guy. ha-ha-ha. I didn't say that :) [..] > @@ -1414,7 +1414,7 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma, > */ > if (unlikely(PageSwapBacked(page) != PageSwapCache(page))) { > WARN_ON_ONCE(1); > - ret = SWAP_FAIL; > + ret = false; > page_vma_mapped_walk_done(&pvmw); > break; > } one thing to notice here is that 'ret = false' and 'ret = SWAP_FAIL' are not the same and must produce different results. `ret' is bool and SWAP_FAIL was 2. it's return 1 vs return 0, isn't it? so was there a bug before? -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org