linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@intel.com>,
	Tim Chen <tim.c.chen@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ying Huang <ying.huang@intel.com>
Subject: Re: [PATCH v2 0/5] mm: support parallel free of memory
Date: Thu, 16 Mar 2017 21:51:22 +0800	[thread overview]
Message-ID: <20170316135122.GF13054@aaronlu.sh.intel.com> (raw)
In-Reply-To: <20170316073403.GE1661@aaronlu.sh.intel.com>

On Thu, Mar 16, 2017 at 03:34:03PM +0800, Aaron Lu wrote:
> On Wed, Mar 15, 2017 at 05:28:43PM +0100, Michal Hocko wrote:
> ... ...
> > After all the amount of the work to be done is the same we just risk
> > more lock contentions, unexpected CPU usage etc.
> 
> I start to realize this is a good question.
> 
> I guess max_active=4 produced almost the best result(max_active=8 is
> only slightly better) is due to the test box is a 4 node machine and
> therefore, there are 4 zone->lock to contend(let's ignore those tiny
> zones only available in node 0).
> 
> I'm going to test on a EP to see if max_active=2 will suffice to produce
> a good enough result. If so, the proper default number should be the
> number of nodes.

Here are test results on 2 nodes EP with 128GiB memory, test size 100GiB.

max_active           time
vanilla              2.971s +-3.8%
2                    1.699s +-13.7%
4                    1.616s +-3.1%
8                    1.642s +-0.9%

So 4 gives best result but 2 is probably good enough.

If the size each worker deals with is changed from 1G to 2G:

max_active           time
2                    1.605s +-1.7%
4                    1.639s +-1.2%
8                    1.626s +-1.8%

Considering that we are mostly improving for memory intensive apps, the
default setting should probably be: max_active = node_number with each
worker freeing 2G memory.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-03-16 13:51 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15  8:59 [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu
2017-03-15  9:00 ` [PATCH v2 1/5] mm: add tlb_flush_mmu_free_batches Aaron Lu
2017-03-15  9:00 ` [PATCH v2 2/5] mm: parallel free pages Aaron Lu
2017-03-15  9:42   ` Hillf Danton
2017-03-15 11:54     ` Aaron Lu
2017-03-15  9:00 ` [PATCH v2 3/5] mm: use a dedicated workqueue for the free workers Aaron Lu
2017-03-22  6:33   ` Minchan Kim
2017-03-22  8:41     ` Aaron Lu
2017-03-22  8:55       ` Minchan Kim
2017-03-22 13:43         ` Aaron Lu
2017-03-23  5:53           ` Minchan Kim
2017-03-23 15:38       ` Dave Hansen
2017-03-24 12:37         ` Aaron Lu
2017-03-15  9:00 ` [PATCH v2 4/5] mm: add force_free_pages in zap_pte_range Aaron Lu
2017-03-15  9:00 ` [PATCH v2 5/5] mm: add debugfs interface for parallel free tuning Aaron Lu
2017-03-15 14:18 ` [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko
2017-03-15 15:44   ` Aaron Lu
2017-03-15 16:28     ` Michal Hocko
2017-03-15 21:38       ` Tim Chen
2017-03-16  9:07         ` Michal Hocko
2017-03-16 18:36           ` Tim Chen
2017-03-17  7:47             ` Michal Hocko
2017-03-17  8:07               ` Minchan Kim
2017-03-17 12:33               ` Aaron Lu
2017-03-17 12:59                 ` Michal Hocko
2017-03-17 13:16                 ` Peter Zijlstra
2017-03-17 12:53               ` Peter Zijlstra
2017-03-17 13:05                 ` Michal Hocko
2017-03-21 14:54           ` Dave Hansen
2017-03-22  8:02             ` Aaron Lu
2017-03-24  7:04             ` Aaron Lu
2017-03-21 15:18           ` Tim Chen
2017-03-16  6:54       ` Aaron Lu
2017-03-16  7:34       ` Aaron Lu
2017-03-16 13:51         ` Aaron Lu [this message]
2017-03-16 14:14           ` Aaron Lu
2017-03-15 14:56 ` Vlastimil Babka
2017-03-15 15:50   ` Aaron Lu
2017-03-17  3:10   ` Aaron Lu
2017-03-16 19:38 ` Alex Thorlton
2017-03-17  2:21   ` Aaron Lu
2017-03-20 19:15     ` Alex Thorlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170316135122.GF13054@aaronlu.sh.intel.com \
    --to=aaron.lu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=tim.c.chen@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).