From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 820546B0038 for ; Fri, 17 Mar 2017 03:34:43 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id x124so2227978wmf.1 for ; Fri, 17 Mar 2017 00:34:43 -0700 (PDT) Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com. [2a00:1450:400c:c0c::241]) by mx.google.com with ESMTPS id l2si9995077wrb.253.2017.03.17.00.34.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Mar 2017 00:34:42 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id u48so8488721wrc.1 for ; Fri, 17 Mar 2017 00:34:41 -0700 (PDT) Date: Fri, 17 Mar 2017 08:34:37 +0100 From: Ingo Molnar Subject: Re: [PATCH v7 1/3] x86/mm: Adapt MODULES_END based on Fixmap section size Message-ID: <20170317073437.GA14797@gmail.com> References: <20170314170508.100882-1-thgarnie@google.com> <20170316081013.GB7815@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Thomas Garnier Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Jonathan Corbet , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Lorenzo Stoakes , Kees Cook , Juergen Gross , Andy Lutomirski , Paul Gortmaker , Andrew Morton , Michal Hocko , zijun_hu , Chris Wilson , Andy Lutomirski , "Rafael J . Wysocki" , Len Brown , Pavel Machek , Jiri Kosina , Matt Fleming , Ard Biesheuvel , Boris Ostrovsky , Rusty Russell , Paolo Bonzini , Borislav Petkov , Christian Borntraeger , Frederic Weisbecker , "Luis R . Rodriguez" , Stanislaw Gruszka , Peter Zijlstra , Josh Poimboeuf , Vitaly Kuznetsov , Tim Chen , Joerg Roedel , Radim =?utf-8?B?S3LEjW3DocWZ?= , the arch/x86 maintainers , LKML , linux-doc@vger.kernel.org, kasan-dev , Linux-MM , Linux PM list , linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, lguest@lists.ozlabs.org, kvm list , Kernel Hardening * Thomas Garnier wrote: > On Thu, Mar 16, 2017 at 1:10 AM, Ingo Molnar wrote: > > > > Note that asm/fixmap.h is an x86-ism that isn't present in many other > > architectures, so this hunk will break the build. > > > > To make progress with these patches I've fixed it up with an ugly #ifdef > > CONFIG_X86, but it needs a real solution instead before this can be pushed > > upstream. > > I also saw an error on x86 tip on special configuration. I found this > new patch below to be a good solution to both. > > Let me know what you think. > > ===== > > This patch aligns MODULES_END to the beginning of the Fixmap section. > It optimizes the space available for both sections. The address is > pre-computed based on the number of pages required by the Fixmap > section. > > It will allow GDT remapping in the Fixmap section. The current > MODULES_END static address does not provide enough space for the kernel > to support a large number of processors. > > Signed-off-by: Thomas Garnier > --- > Based on next-20170308 > --- > Documentation/x86/x86_64/mm.txt | 5 ++++- > arch/x86/include/asm/pgtable_64.h | 1 + > arch/x86/include/asm/pgtable_64_types.h | 3 ++- > 3 files changed, 7 insertions(+), 2 deletions(-) The patch is heavily whitespace and line wrap damaged :-( Please send a properly titled, changelogged delta patch against tip:master (or tip:x86/mm) to remove the CONFIG_X86 hack and fix the build bug. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org