From: Wei Yang <richard.weiyang@gmail.com>
To: Thomas Garnier <thgarnie@google.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH tip] x86/mm: Correct fixmap header usage on adaptable MODULES_END
Date: Mon, 20 Mar 2017 23:08:07 +0800 [thread overview]
Message-ID: <20170320150807.GA78291@WeideMBP.lan> (raw)
In-Reply-To: <CAJcbSZFE9kgF81eHsbpQ_8Wsw-X=w93X=P8SHFqsaznEuF+XTQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]
On Mon, Mar 20, 2017 at 07:31:17AM -0700, Thomas Garnier wrote:
>On Sun, Mar 19, 2017 at 6:14 PM, Wei Yang <richard.weiyang@gmail.com> wrote:
>> On Sun, Mar 19, 2017 at 09:25:00AM -0700, Thomas Garnier wrote:
>>>On Sun, Mar 19, 2017 at 9:03 AM, Wei Yang <richard.weiyang@gmail.com> wrote:
>>>> On Fri, Mar 17, 2017 at 10:50:34AM -0700, Thomas Garnier wrote:
>>>>>This patch remove fixmap header usage on non-x86 code that was
>>>>>introduced by the adaptable MODULE_END change.
>>>>
>>>> Hi, Thomas
>>>>
>>>> In this patch, it looks you are trying to do two things for my understanding:
>>>> 1. To include <asm/fixmap.h> in asm/pagetable_64.h and remove the include in
>>>> some of the x86 files
>>>> 2. Remove <asm/fixmap.h> in mm/vmalloc.c
>>>>
>>>> I think your change log covers the second task in the patch, but not not talk
>>>> about the first task you did in the patch. If you could mention it in commit
>>>> log, it would be good for maintain.
>>>
>>>I agree, I am not the best at writing commits (by far). What's the
>>>best way for me to correct that? (the bot seem to have taken it).
>>>
>>
>> Simply mention it in your commit log is enough to me.
>>
>
>I meant, do I send another patch or reply on in this thread and bot
>will pick it up?
>
I think it is necessary to send V2.
--
Wei Yang
Help you, Help me
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-03-20 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 17:50 [PATCH tip] x86/mm: Correct fixmap header usage on adaptable MODULES_END Thomas Garnier
2017-03-19 16:03 ` Wei Yang
2017-03-19 16:25 ` Thomas Garnier
2017-03-20 1:14 ` Wei Yang
2017-03-20 14:31 ` Thomas Garnier
2017-03-20 15:08 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320150807.GA78291@WeideMBP.lan \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).