From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vito Caputo <vcaputo@pengaru.com>
Cc: hughd@google.com, linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] shmem: fix __shmem_file_setup error path leaks
Date: Mon, 27 Mar 2017 22:21:27 +0100 [thread overview]
Message-ID: <20170327212127.GF29622@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170327170534.GA16903@shells.gnugeneration.com>
On Mon, Mar 27, 2017 at 10:05:34AM -0700, Vito Caputo wrote:
> The existing path and memory cleanups appear to be in reverse order, and
> there's no iput() potentially leaking the inode in the last two error gotos.
>
> Also make put_memory shmem_unacct_size() conditional on !inode since if we
> entered cleanup at put_inode, shmem_evict_inode() occurs via
> iput()->iput_final(), which performs the shmem_unacct_size() for us.
>
> Signed-off-by: Vito Caputo <vcaputo@pengaru.com>
> ---
>
> This caught my eye while looking through the memfd_create() implementation.
> Included patch was compile tested only...
Obviously so, since you've just introduced a double iput() there. After
d_instantiate(path.dentry, inode);
dropping the reference to path.dentry (done by path_put(&path)) will drop
the reference to inode transferred into that dentry by d_instantiate().
NAK.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-27 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 17:05 [PATCH] shmem: fix __shmem_file_setup error path leaks Vito Caputo
2017-03-27 21:21 ` Al Viro [this message]
2017-03-28 0:52 ` vcaputo
2017-03-28 3:54 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327212127.GF29622@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vcaputo@pengaru.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).