From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f70.google.com (mail-pg0-f70.google.com [74.125.83.70]) by kanga.kvack.org (Postfix) with ESMTP id 0AEAA6B0390 for ; Mon, 17 Apr 2017 03:38:43 -0400 (EDT) Received: by mail-pg0-f70.google.com with SMTP id c2so19782055pga.1 for ; Mon, 17 Apr 2017 00:38:43 -0700 (PDT) Received: from lgeamrelo12.lge.com (LGEAMRELO12.lge.com. [156.147.23.52]) by mx.google.com with ESMTP id 1si10242836plw.137.2017.04.17.00.38.41 for ; Mon, 17 Apr 2017 00:38:41 -0700 (PDT) Date: Mon, 17 Apr 2017 16:38:08 +0900 From: Minchan Kim Subject: Re: [PATCH v7 1/7] mm/page_alloc: don't reserve ZONE_HIGHMEM for ZONE_MOVABLE request Message-ID: <20170417073808.GA21354@bbox> References: <1491880640-9944-1-git-send-email-iamjoonsoo.kim@lge.com> <1491880640-9944-2-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 In-Reply-To: <1491880640-9944-2-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: js1304@gmail.com Cc: Andrew Morton , Rik van Riel , Johannes Weiner , mgorman@techsingularity.net, Laura Abbott , Marek Szyprowski , Michal Nazarewicz , "Aneesh Kumar K . V" , Vlastimil Babka , Russell King , Will Deacon , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Joonsoo Kim Hi Joonsoo, On Tue, Apr 11, 2017 at 12:17:14PM +0900, js1304@gmail.com wrote: > From: Joonsoo Kim > > Freepage on ZONE_HIGHMEM doesn't work for kernel memory so it's not that > important to reserve. When ZONE_MOVABLE is used, this problem would > theorectically cause to decrease usable memory for GFP_HIGHUSER_MOVABLE > allocation request which is mainly used for page cache and anon page > allocation. So, fix it. > > And, defining sysctl_lowmem_reserve_ratio array by MAX_NR_ZONES - 1 size > makes code complex. For example, if there is highmem system, following > reserve ratio is activated for *NORMAL ZONE* which would be easyily > misleading people. > > #ifdef CONFIG_HIGHMEM > 32 > #endif > > This patch also fix this situation by defining sysctl_lowmem_reserve_ratio > array by MAX_NR_ZONES and place "#ifdef" to right place. > > Reviewed-by: Aneesh Kumar K.V > Acked-by: Vlastimil Babka > Signed-off-by: Joonsoo Kim > --- > include/linux/mmzone.h | 2 +- > mm/page_alloc.c | 11 ++++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index ebaccd4..96194bf 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -869,7 +869,7 @@ int min_free_kbytes_sysctl_handler(struct ctl_table *, int, > void __user *, size_t *, loff_t *); > int watermark_scale_factor_sysctl_handler(struct ctl_table *, int, > void __user *, size_t *, loff_t *); > -extern int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1]; > +extern int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES]; > int lowmem_reserve_ratio_sysctl_handler(struct ctl_table *, int, > void __user *, size_t *, loff_t *); > int percpu_pagelist_fraction_sysctl_handler(struct ctl_table *, int, > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 32b31d6..60ffa4e 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -203,17 +203,18 @@ static void __free_pages_ok(struct page *page, unsigned int order); > * TBD: should special case ZONE_DMA32 machines here - in those we normally > * don't need any ZONE_NORMAL reservation > */ > -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES-1] = { > +int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = { > #ifdef CONFIG_ZONE_DMA > - 256, > + [ZONE_DMA] = 256, > #endif > #ifdef CONFIG_ZONE_DMA32 > - 256, > + [ZONE_DMA32] = 256, > #endif > + [ZONE_NORMAL] = 32, > #ifdef CONFIG_HIGHMEM > - 32, > + [ZONE_HIGHMEM] = INT_MAX, > #endif > - 32, > + [ZONE_MOVABLE] = INT_MAX, > }; We need to update lowmem_reserve_ratio in Documentation/sysctl/vm.txt. And to me, INT_MAX is rather awkward. # cat /proc/sys/vm/lowmem_reserve_ratio 256 256 32 2147483647 2147483647 What do you think about to use 0 or -1 as special meaning instead 2147483647? Anyway, it could be separate patch regardless of zone_cma so I hope Andrew to merge this patch regardless of other patches in this patchset. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org