From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: rientjes@google.com, akpm@linux-foundation.org,
linux-mm@kvack.org, hannes@cmpxchg.org, sgruszka@redhat.com
Subject: Re: [PATCH] mm,page_alloc: Split stall warning and failure warning.
Date: Tue, 18 Apr 2017 14:14:35 +0200 [thread overview]
Message-ID: <20170418121434.GP22360@dhcp22.suse.cz> (raw)
In-Reply-To: <201704182049.BIE34837.FJOFOMFOQSLHVt@I-love.SAKURA.ne.jp>
On Tue 18-04-17 20:49:20, Tetsuo Handa wrote:
> David Rientjes wrote:
[...]
> > Otherwise, I think this is a good direction.
>
> So, here we got a conflict. Michal thinks this is a pointless code and
> David thinks this is a good direction. Michal, can you accept
> warn_alloc_stall()/warn_alloc_failed() separation?
This is eating way too much time considering how important it is. The
patch is not fixing any real bug so I do not think this is worth any
additional code. We could tweak around this code for another few months
which I definitely do not have time for that. If you want to fix a
_real_ bug, be explicit about it otherwise I do not see any reason to
change the code.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-04-18 12:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 11:58 [PATCH] mm,page_alloc: Split stall warning and failure warning Tetsuo Handa
2017-04-10 12:39 ` Michal Hocko
2017-04-10 14:23 ` Tetsuo Handa
2017-04-10 22:03 ` Andrew Morton
2017-04-11 7:15 ` Michal Hocko
2017-04-11 11:43 ` Tetsuo Handa
2017-04-11 11:54 ` Michal Hocko
2017-04-11 13:26 ` Tetsuo Handa
2017-04-17 22:48 ` David Rientjes
2017-04-18 11:49 ` Tetsuo Handa
2017-04-18 12:14 ` Michal Hocko [this message]
2017-04-18 21:47 ` David Rientjes
2017-04-19 11:13 ` Michal Hocko
2017-04-19 13:22 ` Stanislaw Gruszka
2017-04-19 13:33 ` Michal Hocko
2017-04-22 8:10 ` Stanislaw Gruszka
2017-04-24 8:42 ` Michal Hocko
2017-04-24 13:06 ` Stanislaw Gruszka
2017-04-24 15:06 ` Tetsuo Handa
2017-04-25 6:36 ` Stanislaw Gruszka
2017-04-19 22:34 ` David Rientjes
2017-04-20 11:46 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418121434.GP22360@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).