From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id D10076B02EE for ; Mon, 15 May 2017 04:59:33 -0400 (EDT) Received: by mail-pg0-f72.google.com with SMTP id x64so106308359pgd.6 for ; Mon, 15 May 2017 01:59:33 -0700 (PDT) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com. [209.85.192.195]) by mx.google.com with ESMTPS id z16si10465643pll.224.2017.05.15.01.59.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 May 2017 01:59:33 -0700 (PDT) Received: by mail-pf0-f195.google.com with SMTP id n23so13932929pfb.3 for ; Mon, 15 May 2017 01:59:33 -0700 (PDT) From: Michal Hocko Subject: [PATCH 02/14] mm, memory_hotplug: use node instead of zone in can_online_high_movable Date: Mon, 15 May 2017 10:58:15 +0200 Message-Id: <20170515085827.16474-3-mhocko@kernel.org> In-Reply-To: <20170515085827.16474-1-mhocko@kernel.org> References: <20170515085827.16474-1-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-mm@kvack.org, Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko , Yasuaki Ishimatsu From: Michal Hocko the primary purpose of this helper is to query the node state so use the node id directly. This is a preparatory patch for later changes. This shouldn't introduce any functional change Acked-by: Vlastimil Babka Reviewed-by: Yasuaki Ishimatsu Signed-off-by: Michal Hocko --- mm/memory_hotplug.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 17dd511614ff..6290d34b6331 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -945,15 +945,15 @@ static int online_pages_range(unsigned long start_pfn, unsigned long nr_pages, * When CONFIG_MOVABLE_NODE, we permit onlining of a node which doesn't have * normal memory. */ -static bool can_online_high_movable(struct zone *zone) +static bool can_online_high_movable(int nid) { return true; } #else /* CONFIG_MOVABLE_NODE */ /* ensure every online node has NORMAL memory */ -static bool can_online_high_movable(struct zone *zone) +static bool can_online_high_movable(int nid) { - return node_state(zone_to_nid(zone), N_NORMAL_MEMORY); + return node_state(nid, N_NORMAL_MEMORY); } #endif /* CONFIG_MOVABLE_NODE */ @@ -1087,7 +1087,7 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ if ((zone_idx(zone) > ZONE_NORMAL || online_type == MMOP_ONLINE_MOVABLE) && - !can_online_high_movable(zone)) + !can_online_high_movable(pfn_to_nid(pfn))) return -EINVAL; if (online_type == MMOP_ONLINE_KERNEL) { -- 2.11.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org