From: "Huang, Ying" <ying.huang@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Huang Ying <ying.huang@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: [PATCH -mm -v11 5/5] mm, THP, swap: Enable THP swap optimization only if has compound map
Date: Mon, 15 May 2017 19:25:22 +0800 [thread overview]
Message-ID: <20170515112522.32457-6-ying.huang@intel.com> (raw)
In-Reply-To: <20170515112522.32457-1-ying.huang@intel.com>
From: Huang Ying <ying.huang@intel.com>
If there is no compound map for a THP (Transparent Huge Page), it is
possible that the map count of some sub-pages of the THP is 0. So it
is better to split the THP before swapping out. In this way, the
sub-pages not mapped will be freed, and we can avoid the unnecessary
swap out operations for these sub-pages.
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
---
mm/vmscan.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index a5355022dc2f..f7e949ac9756 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1125,10 +1125,19 @@ static unsigned long shrink_page_list(struct list_head *page_list,
!PageSwapCache(page)) {
if (!(sc->gfp_mask & __GFP_IO))
goto keep_locked;
- /* cannot split THP, skip it */
- if (PageTransHuge(page) &&
- !can_split_huge_page(page, NULL))
- goto activate_locked;
+ if (PageTransHuge(page)) {
+ /* cannot split THP, skip it */
+ if (!can_split_huge_page(page, NULL))
+ goto activate_locked;
+ /*
+ * Split pages without a PMD map right
+ * away. Chances are some or all of the
+ * tail pages can be freed without IO.
+ */
+ if (!compound_mapcount(page) &&
+ split_huge_page_to_list(page, page_list))
+ goto activate_locked;
+ }
if (!add_to_swap(page)) {
if (!PageTransHuge(page))
goto activate_locked;
--
2.11.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-05-15 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 11:25 [PATCH -mm -v11 0/5] THP swap: Delay splitting THP during swapping out Huang, Ying
2017-05-15 11:25 ` [PATCH -mm -v11 1/5] mm, THP, swap: Delay splitting THP during swap out Huang, Ying
2017-05-18 5:33 ` Huang, Ying
2017-05-15 11:25 ` [PATCH -mm -v11 2/5] mm, THP, swap: Unify swap slot free functions to put_swap_page Huang, Ying
2017-05-15 11:25 ` [PATCH -mm -v11 3/5] mm, THP, swap: Move anonymous THP split logic to vmscan Huang, Ying
2017-05-15 11:25 ` [PATCH -mm -v11 4/5] mm, THP, swap: Check whether THP can be split firstly Huang, Ying
2017-05-15 11:25 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515112522.32457-6-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).