From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id C8A2C6B0292 for ; Mon, 22 May 2017 17:45:04 -0400 (EDT) Received: by mail-pf0-f199.google.com with SMTP id n75so142132560pfh.0 for ; Mon, 22 May 2017 14:45:04 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id 59si18547162pld.76.2017.05.22.14.45.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 14:45:03 -0700 (PDT) Date: Mon, 22 May 2017 14:45:01 -0700 From: Andrew Morton Subject: Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems Message-Id: <20170522144501.2d02b5799e07167dc5aecf3e@linux-foundation.org> In-Reply-To: <20170522205621.GL141096@google.com> References: <20170519210036.146880-1-mka@chromium.org> <20170519210036.146880-2-mka@chromium.org> <20170522205621.GL141096@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Matthias Kaehlcke Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, 22 May 2017 13:56:21 -0700 Matthias Kaehlcke wrote: > El Mon, May 22, 2017 at 01:39:26PM -0700 David Rientjes ha dit: > > > On Fri, 19 May 2017, Matthias Kaehlcke wrote: > > > > > The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef > > > block fixes the following warning when building with clang: > > > > > > mm/slub.c:1246:20: error: unused function 'kmalloc_large_node_hook' > > > [-Werror,-Wunused-function] > > > > > > > Is clang not inlining kmalloc_large_node_hook() for some reason? I don't > > think this should ever warn on gcc. > > clang warns about unused static inline functions outside of header > files, in difference to gcc. I wish it wouldn't. These patches just add clutter. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org