From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Nick Desaulniers <nick.desaulniers@gmail.com>
Cc: md@google.com, mka@chromium.org, Minchan Kim <minchan@kernel.org>,
Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning
Date: Wed, 24 May 2017 17:16:18 +0900 [thread overview]
Message-ID: <20170524081617.GA3311@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170524053859.29059-1-nick.desaulniers@gmail.com>
On (05/23/17 22:38), Nick Desaulniers wrote:
>
> is_first_page() is only called from the macro VM_BUG_ON_PAGE() which is
> only compiled in as a runtime check when CONFIG_DEBUG_VM is set,
> otherwise is checked at compile time and not actually compiled in.
>
> Fixes the following warning, found with Clang:
>
> mm/zsmalloc.c:472:12: warning: function 'is_first_page' is not needed and
> will not be emitted [-Wunneeded-internal-declaration]
> static int is_first_page(struct page *page)
> ^
>
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
well, no objections from my side. MM seems to be getting more and
more `__maybe_unused' annotations because of clang.
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-05-24 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 5:38 [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning Nick Desaulniers
2017-05-24 8:16 ` Sergey Senozhatsky [this message]
2017-05-26 4:15 ` Nick Desaulniers
2017-05-25 5:38 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524081617.GA3311@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=md@google.com \
--cc=minchan@kernel.org \
--cc=mka@chromium.org \
--cc=ngupta@vflare.org \
--cc=nick.desaulniers@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).