From: "Jérôme Glisse" <jglisse@redhat.com>
To: linux-mm@kvack.org
Cc: "Jérôme Glisse" <jglisse@redhat.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCH] x86/mm: do not BUG_ON() on stall pgd entries
Date: Wed, 31 May 2017 11:03:49 -0400 [thread overview]
Message-ID: <20170531150349.4816-1-jglisse@redhat.com> (raw)
Since af2cf278ef4f ("Don't remove PGD entries in remove_pagetable()")
we no longer cleanup stall pgd entries and thus the BUG_ON() inside
sync_global_pgds() is wrong.
This patch remove the BUG_ON() and unconditionaly update stall pgd
entries.
Signed-off-by: JA(C)rA'me Glisse <jglisse@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
arch/x86/mm/init_64.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index ff95fe8..36b9020 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -123,12 +123,7 @@ void sync_global_pgds(unsigned long start, unsigned long end)
pgt_lock = &pgd_page_get_mm(page)->page_table_lock;
spin_lock(pgt_lock);
- if (!p4d_none(*p4d_ref) && !p4d_none(*p4d))
- BUG_ON(p4d_page_vaddr(*p4d)
- != p4d_page_vaddr(*p4d_ref));
-
- if (p4d_none(*p4d))
- set_p4d(p4d, *p4d_ref);
+ set_p4d(p4d, *p4d_ref);
spin_unlock(pgt_lock);
}
--
2.9.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-05-31 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 15:03 Jérôme Glisse [this message]
2017-06-01 9:57 ` [PATCH] x86/mm: do not BUG_ON() on stall pgd entries Kirill A. Shutemov
2017-06-01 13:59 ` Andy Lutomirski
2017-06-01 14:33 ` Jerome Glisse
2017-06-01 14:38 ` Andy Lutomirski
2017-06-01 15:11 ` Jerome Glisse
2017-06-01 18:38 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531150349.4816-1-jglisse@redhat.com \
--to=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).