* [PATCH] mm/page_alloc: Trivial typo fix.
@ 2017-06-05 1:43 Wei Yang
2017-06-05 6:22 ` Michal Hocko
0 siblings, 1 reply; 5+ messages in thread
From: Wei Yang @ 2017-06-05 1:43 UTC (permalink / raw)
To: trivial, akpm, mhocko; +Cc: linux-mm, Wei Yang
Looks there is no word "blamo", and it should be "blame".
This patch just fix the typo.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 07efbc3a8656..9ce765e6fe2f 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3214,7 +3214,7 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order,
if (gfp_mask & __GFP_THISNODE)
goto out;
- /* Exhausted what can be done so it's blamo time */
+ /* Exhausted what can be done so it's blame time */
if (out_of_memory(&oc) || WARN_ON_ONCE(gfp_mask & __GFP_NOFAIL)) {
*did_some_progress = 1;
--
2.11.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mm/page_alloc: Trivial typo fix.
2017-06-05 1:43 [PATCH] mm/page_alloc: Trivial typo fix Wei Yang
@ 2017-06-05 6:22 ` Michal Hocko
2017-06-05 22:29 ` Andrew Morton
2017-06-06 3:06 ` Wei Yang
0 siblings, 2 replies; 5+ messages in thread
From: Michal Hocko @ 2017-06-05 6:22 UTC (permalink / raw)
To: Wei Yang; +Cc: trivial, akpm, linux-mm
On Mon 05-06-17 09:43:50, Wei Yang wrote:
> Looks there is no word "blamo", and it should be "blame".
>
> This patch just fix the typo.
Well, I do not think this is a typo. blamo has a slang meaning which I
believe was intentional. Besides that, why would you want to fix this
anyway. Is this something that you would grep for?
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 07efbc3a8656..9ce765e6fe2f 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3214,7 +3214,7 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order,
> if (gfp_mask & __GFP_THISNODE)
> goto out;
>
> - /* Exhausted what can be done so it's blamo time */
> + /* Exhausted what can be done so it's blame time */
> if (out_of_memory(&oc) || WARN_ON_ONCE(gfp_mask & __GFP_NOFAIL)) {
> *did_some_progress = 1;
>
> --
> 2.11.0
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm/page_alloc: Trivial typo fix.
2017-06-05 6:22 ` Michal Hocko
@ 2017-06-05 22:29 ` Andrew Morton
2017-06-06 3:07 ` Wei Yang
2017-06-06 3:06 ` Wei Yang
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2017-06-05 22:29 UTC (permalink / raw)
To: Michal Hocko; +Cc: Wei Yang, trivial, linux-mm
On Mon, 5 Jun 2017 08:22:48 +0200 Michal Hocko <mhocko@kernel.org> wrote:
> On Mon 05-06-17 09:43:50, Wei Yang wrote:
> > Looks there is no word "blamo", and it should be "blame".
> >
> > This patch just fix the typo.
>
> Well, I do not think this is a typo. blamo has a slang meaning which I
> believe was intentional.
It should be "blammo".
> Besides that, why would you want to fix this
> anyway. Is this something that you would grep for?
Yup. I wouldn't object to an incidental fix if someone was altering
something else nearby or as part of a file-wide "clean up comments"
patch, but it doesn't seem worth an entire commit.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/page_alloc: Trivial typo fix.
2017-06-05 22:29 ` Andrew Morton
@ 2017-06-06 3:07 ` Wei Yang
0 siblings, 0 replies; 5+ messages in thread
From: Wei Yang @ 2017-06-06 3:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: Michal Hocko, Wei Yang, trivial, linux-mm
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On Mon, Jun 05, 2017 at 03:29:05PM -0700, Andrew Morton wrote:
>On Mon, 5 Jun 2017 08:22:48 +0200 Michal Hocko <mhocko@kernel.org> wrote:
>
>> On Mon 05-06-17 09:43:50, Wei Yang wrote:
>> > Looks there is no word "blamo", and it should be "blame".
>> >
>> > This patch just fix the typo.
>>
>> Well, I do not think this is a typo. blamo has a slang meaning which I
>> believe was intentional.
>
>It should be "blammo".
>
>> Besides that, why would you want to fix this
>> anyway. Is this something that you would grep for?
>
>Yup. I wouldn't object to an incidental fix if someone was altering
>something else nearby or as part of a file-wide "clean up comments"
>patch, but it doesn't seem worth an entire commit.
Sure, maybe I can keep this when I have other related patches. :-)
--
Wei Yang
Help you, Help me
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/page_alloc: Trivial typo fix.
2017-06-05 6:22 ` Michal Hocko
2017-06-05 22:29 ` Andrew Morton
@ 2017-06-06 3:06 ` Wei Yang
1 sibling, 0 replies; 5+ messages in thread
From: Wei Yang @ 2017-06-06 3:06 UTC (permalink / raw)
To: Michal Hocko; +Cc: Wei Yang, trivial, akpm, linux-mm
[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]
On Mon, Jun 05, 2017 at 08:22:48AM +0200, Michal Hocko wrote:
>On Mon 05-06-17 09:43:50, Wei Yang wrote:
>> Looks there is no word "blamo", and it should be "blame".
>>
>> This patch just fix the typo.
>
>Well, I do not think this is a typo. blamo has a slang meaning which I
>believe was intentional. Besides that, why would you want to fix this
>anyway. Is this something that you would grep for?
>
Oh, I thought it was wrong, so I did this change.
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> ---
>> mm/page_alloc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 07efbc3a8656..9ce765e6fe2f 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -3214,7 +3214,7 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order,
>> if (gfp_mask & __GFP_THISNODE)
>> goto out;
>>
>> - /* Exhausted what can be done so it's blamo time */
>> + /* Exhausted what can be done so it's blame time */
>> if (out_of_memory(&oc) || WARN_ON_ONCE(gfp_mask & __GFP_NOFAIL)) {
>> *did_some_progress = 1;
>>
>> --
>> 2.11.0
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
>--
>Michal Hocko
>SUSE Labs
--
Wei Yang
Help you, Help me
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-06 3:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-05 1:43 [PATCH] mm/page_alloc: Trivial typo fix Wei Yang
2017-06-05 6:22 ` Michal Hocko
2017-06-05 22:29 ` Andrew Morton
2017-06-06 3:07 ` Wei Yang
2017-06-06 3:06 ` Wei Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).