From: Christoph Hellwig <hch@infradead.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Igor Stoppa <igor.stoppa@huawei.com>,
keescook@chromium.org, mhocko@kernel.org, jmorris@namei.org,
paul@paul-moore.com, sds@tycho.nsa.gov, casey@schaufler-ca.com,
hch@infradead.org, labbott@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCH 2/5] Protectable Memory Allocator
Date: Mon, 5 Jun 2017 23:25:06 -0700 [thread overview]
Message-ID: <20170606062505.GA18315@infradead.org> (raw)
In-Reply-To: <201706060444.v564iWds024768@www262.sakura.ne.jp>
On Tue, Jun 06, 2017 at 01:44:32PM +0900, Tetsuo Handa wrote:
> Igor Stoppa wrote:
> > +int pmalloc_protect_pool(struct pmalloc_pool *pool)
> > +{
> > + struct pmalloc_node *node;
> > +
> > + if (!pool)
> > + return -EINVAL;
> > + mutex_lock(&pool->nodes_list_mutex);
> > + hlist_for_each_entry(node, &pool->nodes_list_head, nodes_list) {
> > + unsigned long size, pages;
> > +
> > + size = WORD_SIZE * node->total_words + HEADER_SIZE;
> > + pages = size / PAGE_SIZE;
> > + set_memory_ro((unsigned long)node, pages);
> > + }
> > + pool->protected = true;
> > + mutex_unlock(&pool->nodes_list_mutex);
> > + return 0;
> > +}
>
> As far as I know, not all CONFIG_MMU=y architectures provide
> set_memory_ro()/set_memory_rw(). You need to provide fallback for
> architectures which do not provide set_memory_ro()/set_memory_rw()
> or kernels built with CONFIG_MMU=n.
I think we'll just need to generalize CONFIG_STRICT_MODULE_RWX and/or
ARCH_HAS_STRICT_MODULE_RWX so there is a symbol to key this off.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-06 6:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 19:22 Igor Stoppa
2017-06-05 19:22 ` [PATCH 1/5] LSM: Convert security_hook_heads into explicit array of struct list_head Igor Stoppa
2017-06-05 19:22 ` [PATCH 2/5] Protectable Memory Allocator Igor Stoppa
2017-06-06 4:44 ` Tetsuo Handa
2017-06-06 6:25 ` Christoph Hellwig [this message]
2017-06-06 11:34 ` Igor Stoppa
2017-06-06 16:24 ` Laura Abbott
2017-06-06 11:42 ` Igor Stoppa
2017-06-06 12:08 ` Tetsuo Handa
2017-06-06 12:23 ` Igor Stoppa
2017-06-05 19:22 ` [PATCH 3/5] Protectable Memory Allocator - Debug interface Igor Stoppa
2017-06-05 20:24 ` [kernel-hardening] " Jann Horn
2017-06-06 9:00 ` Igor Stoppa
2017-06-05 19:22 ` [PATCH 4/5] Make LSM Writable Hooks a command line option Igor Stoppa
2017-06-05 19:53 ` Casey Schaufler
2017-06-05 20:50 ` Tetsuo Handa
2017-06-06 8:58 ` Igor Stoppa
2017-06-06 10:54 ` Tetsuo Handa
2017-06-06 11:12 ` Igor Stoppa
2017-06-06 11:42 ` Tetsuo Handa
2017-06-06 12:11 ` Igor Stoppa
2017-06-06 14:36 ` Tetsuo Handa
2017-06-06 14:51 ` Igor Stoppa
2017-06-06 15:17 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606062505.GA18315@infradead.org \
--to=hch@infradead.org \
--cc=casey@schaufler-ca.com \
--cc=igor.stoppa@huawei.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=paul@paul-moore.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).