From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: "Jérôme Glisse" <jglisse@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Logan Gunthorpe <logang@deltatee.com>
Subject: Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove
Date: Wed, 7 Jun 2017 13:47:15 +0300 [thread overview]
Message-ID: <20170607104715.5niuwk42fhahbftk@node.shutemov.name> (raw)
In-Reply-To: <20170606173512.7378-1-jglisse@redhat.com>
On Tue, Jun 06, 2017 at 01:35:12PM -0400, Jerome Glisse wrote:
> With commit af2cf278ef4f we no longer free pud so that we
> do not have synchronize all pgd on hotremove/vfree. But the
> new 5 level page table code re-added that code f2a6a705 and
> thus we now trigger a BUG_ON() l128 in sync_global_pgds()
>
> This patch remove free_pud() like in af2cf278ef4f
Good catch. Thanks!
But I think we only need to skip free_pud_table() for 4-level paging.
If we don't we would leave 513 page tables around instead of one in
5-level paging case.
I don't think it's acceptable.
And please use patch subject lines along with commit hashes to simplify
reading commit message.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-07 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 17:35 [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove Jérôme Glisse
2017-06-06 19:50 ` Logan Gunthorpe
2017-06-07 10:47 ` Kirill A. Shutemov [this message]
2017-06-07 14:49 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607104715.5niuwk42fhahbftk@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).