linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: mhocko@kernel.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
	Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH 2/2] mm/memory_hotplug: remove duplicate call for set_page_links
Date: Fri, 16 Jun 2017 17:23:35 +0800	[thread overview]
Message-ID: <20170616092335.5177-2-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20170616092335.5177-1-richard.weiyang@gmail.com>

In function move_pfn_range_to_zone(), memmap_init_zone() will call
set_page_links for each page. This means we don't need to call it on each
page explicitly.

This patch just removes the loop.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 mm/memory_hotplug.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index d61509752112..4fb1fb2b2b53 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -914,10 +914,6 @@ void __ref move_pfn_range_to_zone(struct zone *zone,
 	 * are reserved so nobody should be touching them so we should be safe
 	 */
 	memmap_init_zone(nr_pages, nid, zone_idx(zone), start_pfn, MEMMAP_HOTPLUG);
-	for (i = 0; i < nr_pages; i++) {
-		unsigned long pfn = start_pfn + i;
-		set_page_links(pfn_to_page(pfn), zone_idx(zone), nid, pfn);
-	}
 
 	set_zone_contiguous(zone);
 }
-- 
2.11.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-06-16  9:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16  9:23 [PATCH 1/2] mmzone: simplify zone_intersects() Wei Yang
2017-06-16  9:23 ` Wei Yang [this message]
2017-06-16 17:33   ` [PATCH 2/2] mm/memory_hotplug: remove duplicate call for set_page_links Andrew Morton
2017-06-17  2:55     ` Wei Yang
2017-06-22  6:50     ` Michal Hocko
2017-06-18 16:59 ` [PATCH 1/2] mmzone: simplify zone_intersects() Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170616092335.5177-2-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).