From: Punit Agrawal <punit.agrawal@arm.com>
To: akpm@linux-foundation.org
Cc: Punit Agrawal <punit.agrawal@arm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com, n-horiguchi@ah.jp.nec.com,
kirill.shutemov@linux.intel.com, mike.kravetz@oracle.com,
steve.capper@arm.com, mark.rutland@arm.com,
linux-arch@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com
Subject: [PATCH v5 8/8] mm: rmap: Use correct helper when poisoning hugepages
Date: Mon, 19 Jun 2017 18:01:45 +0100 [thread overview]
Message-ID: <20170619170145.25577-9-punit.agrawal@arm.com> (raw)
In-Reply-To: <20170619170145.25577-1-punit.agrawal@arm.com>
Using set_pte_at() does not do the right thing when putting down
HWPOISON swap entries for hugepages on architectures that support
contiguous ptes.
Fix this problem by using set_huge_swap_pte_at() which was introduced to
fix exactly this problem.
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Acked-by: Steve Capper <steve.capper@arm.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
---
mm/rmap.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/mm/rmap.c b/mm/rmap.c
index d405f0e0ee96..feb2352aa95f 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -1379,15 +1379,18 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
update_hiwater_rss(mm);
if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) {
+ pteval = swp_entry_to_pte(make_hwpoison_entry(subpage));
if (PageHuge(page)) {
int nr = 1 << compound_order(page);
hugetlb_count_sub(nr, mm);
+ set_huge_swap_pte_at(mm, address,
+ pvmw.pte, pteval,
+ vma_mmu_pagesize(vma));
} else {
dec_mm_counter(mm, mm_counter(page));
+ set_pte_at(mm, address, pvmw.pte, pteval);
}
- pteval = swp_entry_to_pte(make_hwpoison_entry(subpage));
- set_pte_at(mm, address, pvmw.pte, pteval);
} else if (pte_unused(pteval)) {
/*
* The guest indicated that the page content is of no
--
2.11.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-19 17:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 17:01 [PATCH v5 0/8] Support for contiguous pte hugepages Punit Agrawal
2017-06-19 17:01 ` [PATCH v5 1/8] arm64: hugetlb: Refactor find_num_contig Punit Agrawal
2017-06-19 17:01 ` [PATCH v5 2/8] arm64: hugetlb: Remove spurious calls to huge_ptep_offset Punit Agrawal
2017-06-19 17:01 ` [PATCH v5 3/8] mm, gup: Remove broken VM_BUG_ON_PAGE compound check for hugepages Punit Agrawal
2017-06-19 17:01 ` [PATCH v5 4/8] mm, gup: Ensure real head page is ref-counted when using hugepages Punit Agrawal
2017-06-19 17:01 ` [PATCH v5 5/8] mm/hugetlb: add size parameter to huge_pte_offset() Punit Agrawal
2017-06-19 17:01 ` [PATCH v5 6/8] mm/hugetlb: Allow architectures to override huge_pte_clear() Punit Agrawal
2017-06-19 17:01 ` [PATCH v5 7/8] mm/hugetlb: Introduce set_huge_swap_pte_at() helper Punit Agrawal
2017-06-19 17:01 ` Punit Agrawal [this message]
2017-06-19 22:01 ` [PATCH v5 0/8] Support for contiguous pte hugepages Andrew Morton
2017-06-20 13:39 ` Punit Agrawal
2017-06-20 21:08 ` Andrew Morton
2017-06-21 12:32 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619170145.25577-9-punit.agrawal@arm.com \
--to=punit.agrawal@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=steve.capper@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).