From: Michal Hocko <mhocko@kernel.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs/memory-hotplug: adjust the explanation of valid_zones sysfs
Date: Thu, 22 Jun 2017 20:21:14 +0200 [thread overview]
Message-ID: <20170622182113.GC19563@dhcp22.suse.cz> (raw)
In-Reply-To: <20170622041844.9852-1-richard.weiyang@gmail.com>
On Thu 22-06-17 12:18:44, Wei Yang wrote:
[...]
> -'valid_zones' : read-only: designed to show which zones this memory block
> - can be onlined to.
> - The first column shows it's default zone.
> +'valid_zones' : read-only: shows different information based on state.
> + When state is online, it is designed to show the
> + zone name this memory block is onlined to.
> + When state is offline, it is designed to show which zones
> + this memory block can be onlined to. The first column
> + shows it's default zone.
I do not think we really need to touch this. First of all the last
sentence is not really correct. The ordering of zones doesn't tell which
zone will be onlined by default. This is indeed a change of behavior of
my patch. I am just not sure anybody depends on that. I can fix it up
but again the old semantic was just awkward and I didn't feel like I
should keep it. Also I plan to change this behavior again with planned
patches. I would like to get rid of the non-overlapping zones
restriction so the wording would have to change again.
That being said, let's keep the wording as it is now.
Thanks!
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-22 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 4:18 [PATCH] docs/memory-hotplug: adjust the explanation of valid_zones sysfs Wei Yang
2017-06-22 18:21 ` Michal Hocko [this message]
2017-06-23 1:41 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622182113.GC19563@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).