Re: [RFC PATCH 3/4] mm/hotplug: make __add_pages() iterate on memory_block and split __add_section()

[Wei Yang <richard.weiyang@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

On Mon, Jun 26, 2017 at 11:47:38PM -0700, John Hubbard wrote:
>On 06/26/2017 04:53 PM, Wei Yang wrote:
>> On Mon, Jun 26, 2017 at 12:50:14AM -0700, John Hubbard wrote:
>>> On 06/24/2017 07:52 PM, Wei Yang wrote:
>[...]
>>>
>>> Things have changed...the register_new_memory() routine is accepting a single section,
>>> but instead of registering just that section, it is registering a containing block.
>>> (That works, because apparently the approach is to make sections_per_block == 1,
>>> and eventually kill sections, if I am reading all this correctly.)
>>>
>> 
>> The original function is a little confusing. Actually it tries to register a
>> memory_block while it register it for several times, on each present
>> mem_section actually.
>> 
>> This change here will register the whole memory_block at once.
>> 
>> You would see in next patch it will accept the start section number instead of
>> a section, while maybe more easy to understand it.
>
>Yes I saw that, and it does help, but even after that, I still thought
>we should add that "* Register an entire memory_block."  line.
>

Well, it is fine to me.


-- 
Wei Yang
Help you, Help me

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]