From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
"karam . lee" <karam.lee@lge.com>,
seungho1.park@lge.com, Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
jack@suse.cz, Jens Axboe <axboe@kernel.dk>,
Vishal Verma <vishal.l.verma@intel.com>,
linux-nvdimm@lists.01.org, kernel-team <kernel-team@lge.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v1 5/6] zram: remove zram_rw_page
Date: Tue, 8 Aug 2017 17:13:38 +0900 [thread overview]
Message-ID: <20170808081338.GA30908@bbox> (raw)
In-Reply-To: <20170808070226.GC7765@jagdpanzerIV.localdomain>
Hi Sergey,
On Tue, Aug 08, 2017 at 04:02:26PM +0900, Sergey Senozhatsky wrote:
> On (08/08/17 15:50), Minchan Kim wrote:
> > With on-stack-bio, rw_page interface doesn't provide a clear performance
> > benefit for zram and surely has a maintenance burden, so remove the
> > last user to remove rw_page completely.
>
> OK, never really liked it, I think we had that conversation before.
>
> as far as I remember, zram_rw_page() was the reason we had to do some
> tricks with init_lock to make lockdep happy. may be now we can "simplify"
> the things back.
I cannot remember. Blame my brain. ;-)
Anyway, it's always welcome to make thing simple.
Could you send a patch after settle down this patchset?
>
>
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
>
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Thanks for the review!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-08 8:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 6:50 [PATCH v1 0/6] Remove rw_page Minchan Kim
2017-08-08 6:50 ` [PATCH v1 1/6] bdi: introduce BDI_CAP_SYNC Minchan Kim
2017-08-08 6:50 ` [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability Minchan Kim
2017-08-08 12:49 ` Matthew Wilcox
2017-08-08 13:29 ` Matthew Wilcox
2017-08-09 1:51 ` Minchan Kim
2017-08-09 2:31 ` Matthew Wilcox
2017-08-09 2:41 ` Minchan Kim
2017-08-10 3:04 ` Matthew Wilcox
2017-08-10 3:06 ` Dan Williams
2017-08-11 10:46 ` Christoph Hellwig
2017-08-11 14:26 ` Jens Axboe
2017-08-14 8:50 ` Minchan Kim
2017-08-14 14:36 ` Jens Axboe
2017-08-14 15:06 ` Minchan Kim
2017-08-14 15:14 ` Jens Axboe
2017-08-14 15:31 ` Minchan Kim
2017-08-14 15:38 ` Jens Axboe
2017-08-14 16:17 ` Jens Axboe
2017-08-16 4:48 ` Minchan Kim
2017-08-16 15:56 ` Jens Axboe
2017-08-21 6:13 ` Minchan Kim
2017-08-14 8:48 ` Minchan Kim
2017-08-10 4:00 ` Minchan Kim
2017-08-09 1:48 ` Minchan Kim
2017-08-08 6:50 ` [PATCH v1 3/6] mm:swap: remove end_swap_bio_write argument Minchan Kim
2017-08-08 6:50 ` [PATCH v1 4/6] mm:swap: use on-stack-bio for BDI_CAP_SYNC devices Minchan Kim
2017-08-08 6:50 ` [PATCH v1 5/6] zram: remove zram_rw_page Minchan Kim
2017-08-08 7:02 ` Sergey Senozhatsky
2017-08-08 8:13 ` Minchan Kim [this message]
2017-08-08 8:23 ` Sergey Senozhatsky
2017-08-08 15:48 ` Matthew Wilcox
2017-08-08 6:50 ` [PATCH v1 6/6] fs: remove rw_page Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808081338.GA30908@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=karam.lee@lge.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=seungho1.park@lge.com \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).