Re: [PATCH v8 00/14] lockdep: Implement crossrelease feature

Ingo Molnar
2017-08-17T08:12:29Z

* Boqun Feng <boqun.feng@gmail.com> wrote:

> > BTW., I don't think the #ifdef is necessary: lockdep_init_map_crosslock should map
> > to nothing when lockdep is disabled, right?
>
> IIUC, lockdep_init_map_crosslock is only defined when
> CONFIG_LOCKDEP_CROSSRELEASE=y,

Then lockdep_init_map_crosslock() should be defined in the !LOCKDEP case as well.

> [...] moreover, completion::map, which used as
> the parameter of lockdep_init_map_crosslock(), is only defined when
> CONFIG_LOCKDEP_COMPLETE=y.

If the !LOCKDEP wrapper is a CPP macro then it can ignore that parameter just
fine, and it won't be built.

Thanks,

Ingo