Re: [PATCH v8 06/14] lockdep: Detect and handle hist_lock ring buffer overwrite

Byungchul Park
2017-08-14T07:30:21Z

On Mon, Aug 14, 2017 at 03:05:22PM +0800, Boqun Feng wrote:
> > 1. Boqun's approach
>
> My approach requires(additionally):
>
> MAX_XHLOCKS_NR * sizeof(unsigned int) // because of the hist_id field in hist_lock
>
> bytes per task.
>
> > 2. Peterz's approach
>
> And Peter's approach requires(additionally):
>
> 1 * sizeof(unsigned int)
>
> bytes per task.
>
> So basically we need some tradeoff between memory footprints and history
> precision here.

I see what you intended. Then, Peterz's one looks better.