From: Andrew Morton <akpm@linux-foundation.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Vlastimil Babka <vbabka@suse.cz>, Hugh Dickins <hughd@google.com>,
Greg Thelen <gthelen@google.com>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] mm: fadvise: avoid fadvise for fs without backing device
Date: Fri, 18 Aug 2017 14:34:50 -0700 [thread overview]
Message-ID: <20170818143450.7584a3f86abf96f4c43fccd0@linux-foundation.org> (raw)
In-Reply-To: <CALvZod444NZaw9wcdSMs5Y60a0cV4j9SEt-TLBJT34OJ_yg3CQ@mail.gmail.com>
On Thu, 17 Aug 2017 18:20:17 -0700 Shakeel Butt <shakeelb@google.com> wrote:
> +linux-mm, linux-kernel
>
> On Thu, Aug 17, 2017 at 6:10 PM, Shakeel Butt <shakeelb@google.com> wrote:
> > The fadvise() manpage is silent on fadvise()'s effect on
> > memory-based filesystems (shmem, hugetlbfs & ramfs) and pseudo
> > file systems (procfs, sysfs, kernfs). The current implementaion
> > of fadvise is mostly a noop for such filesystems except for
> > FADV_DONTNEED which will trigger expensive remote LRU cache
> > draining. This patch makes the noop of fadvise() on such file
> > systems very explicit.
> >
> > However this change has two side effects for ramfs and one for
> > tmpfs. First fadvise(FADV_DONTNEED) can remove the unmapped clean
> > zero'ed pages of ramfs (allocated through read, readahead & read
> > fault) and tmpfs (allocated through read fault). Also
> > fadvise(FADV_WILLNEED) on create such clean zero'ed pages for
> > ramfs. This change removes these two interfaces.
> >
It doesn't sound like a risky change to me, although perhaps someone is
depending on the current behaviour for obscure reasons, who knows.
What are the reasons for this change? Is the current behaviour causing
some sort of problem for someone?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-18 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170818011023.181465-1-shakeelb@google.com>
2017-08-18 1:20 ` [RFC PATCH] mm: fadvise: avoid fadvise for fs without backing device Shakeel Butt
2017-08-18 21:34 ` Andrew Morton [this message]
2017-08-18 23:17 ` Shakeel Butt
2017-08-23 0:25 ` Shakeel Butt
2017-08-25 21:49 ` Andrew Morton
2017-08-26 0:22 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818143450.7584a3f86abf96f4c43fccd0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).