From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197]) by kanga.kvack.org (Postfix) with ESMTP id 7F8CA6810C8 for ; Fri, 25 Aug 2017 16:49:18 -0400 (EDT) Received: by mail-wr0-f197.google.com with SMTP id w14so1220538wrc.5 for ; Fri, 25 Aug 2017 13:49:18 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id u83si1876039wmb.57.2017.08.25.13.49.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Aug 2017 13:49:17 -0700 (PDT) Date: Fri, 25 Aug 2017 13:49:14 -0700 From: Andrew Morton Subject: Re: [Intel-gfx] [PATCH 01/23] mm/shmem: introduce shmem_file_setup_with_mnt Message-Id: <20170825134914.50a2433a5f28ba6ac0ec708d@linux-foundation.org> In-Reply-To: References: <20170821183503.12246-1-matthew.auld@intel.com> <20170821183503.12246-2-matthew.auld@intel.com> <1503480688.6276.4.camel@linux.intel.com> <20170823153456.b3c50e1ec109fd69f672b348@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Auld Cc: Joonas Lahtinen , linux-mm@kvack.org, Intel Graphics Development , Hugh Dickins , Dave Hansen , Matthew Auld , "Kirill A . Shutemov" On Thu, 24 Aug 2017 13:04:09 +0100 Matthew Auld wrote: > On 23 August 2017 at 23:34, Andrew Morton wrote: > > On Wed, 23 Aug 2017 12:31:28 +0300 Joonas Lahtinen wrote: > > > >> This patch has been floating around for a while now Acked and without > >> further comments. It is blocking us from merging huge page support to > >> drm/i915. > >> > >> Would you mind merging it, or prodding the right people to get it in? > >> > >> Regards, Joonas > >> > >> On Mon, 2017-08-21 at 19:34 +0100, Matthew Auld wrote: > >> > We are planning to use our own tmpfs mnt in i915 in place of the > >> > shm_mnt, such that we can control the mount options, in particular > >> > huge=, which we require to support huge-gtt-pages. So rather than roll > >> > our own version of __shmem_file_setup, it would be preferred if we could > >> > just give shmem our mnt, and let it do the rest. > > > > hm, it's a bit odd. I'm having trouble locating the code which handles > > huge=within_size (and any other options?). > > See here https://patchwork.freedesktop.org/patch/172771/, currently we > only care about huge=within_size. > > > What other approaches were considered? > > We also tried https://patchwork.freedesktop.org/patch/156528/, where > it was suggested that we mount our own tmpfs instance. > > Following from that we now have our own tmps mnt mounted with > huge=within_size. With this patch we avoid having to roll our own > __shmem_file_setup like in > https://patchwork.freedesktop.org/patch/163024/. > > > Was it not feasible to add i915-specific mount options to > > mm/shmem.c (for example?). > > Hmm, I think within_size should suffice for our needs. hm, ok, well, unless someone can think of something cleaner, please add my ack and include it in the appropriate drm tree. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org