From: Dimitri Sivanich <sivanich@hpe.com>
To: jglisse@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dimitri Sivanich <sivanich@hpe.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH 10/13] sgi-gru: update to new mmu_notifier semantic
Date: Tue, 5 Sep 2017 11:21:12 -0500 [thread overview]
Message-ID: <20170905162112.GC14176@hpe.com> (raw)
In-Reply-To: <20170831211738.17922-11-jglisse@redhat.com>
Acked-by: Dimitri Sivanich <sivanich@hpe.com>
On Thu, Aug 31, 2017 at 05:17:35PM -0400, jglisse@redhat.com wrote:
> From: Jerome Glisse <jglisse@redhat.com>
>
> Call to mmu_notifier_invalidate_page() are replaced by call to
> mmu_notifier_invalidate_range() and thus call are bracketed by
> call to mmu_notifier_invalidate_range_start()/end()
>
> Remove now useless invalidate_page callback.
>
> Signed-off-by: Jerome Glisse <jglisse@redhat.com>
> Cc: Dimitri Sivanich <sivanich@sgi.com>
> Cc: Jack Steiner <steiner@sgi.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> ---
> drivers/misc/sgi-gru/grutlbpurge.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/misc/sgi-gru/grutlbpurge.c b/drivers/misc/sgi-gru/grutlbpurge.c
> index e936d43895d2..9918eda0e05f 100644
> --- a/drivers/misc/sgi-gru/grutlbpurge.c
> +++ b/drivers/misc/sgi-gru/grutlbpurge.c
> @@ -247,17 +247,6 @@ static void gru_invalidate_range_end(struct mmu_notifier *mn,
> gru_dbg(grudev, "gms %p, start 0x%lx, end 0x%lx\n", gms, start, end);
> }
>
> -static void gru_invalidate_page(struct mmu_notifier *mn, struct mm_struct *mm,
> - unsigned long address)
> -{
> - struct gru_mm_struct *gms = container_of(mn, struct gru_mm_struct,
> - ms_notifier);
> -
> - STAT(mmu_invalidate_page);
> - gru_flush_tlb_range(gms, address, PAGE_SIZE);
> - gru_dbg(grudev, "gms %p, address 0x%lx\n", gms, address);
> -}
> -
> static void gru_release(struct mmu_notifier *mn, struct mm_struct *mm)
> {
> struct gru_mm_struct *gms = container_of(mn, struct gru_mm_struct,
> @@ -269,7 +258,6 @@ static void gru_release(struct mmu_notifier *mn, struct mm_struct *mm)
>
>
> static const struct mmu_notifier_ops gru_mmuops = {
> - .invalidate_page = gru_invalidate_page,
> .invalidate_range_start = gru_invalidate_range_start,
> .invalidate_range_end = gru_invalidate_range_end,
> .release = gru_release,
> --
> 2.13.5
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-05 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 21:17 [PATCH 00/13] mmu_notifier kill invalidate_page callback v2 jglisse
2017-08-31 21:17 ` [PATCH 01/13] dax: update to new mmu_notifier semantic jglisse
2017-09-02 13:35 ` Andrea Arcangeli
2017-08-31 21:17 ` [PATCH 02/13] mm/rmap: update to new mmu_notifier semantic v2 jglisse
2017-08-31 21:17 ` [PATCH 03/13] powerpc/powernv: update to new mmu_notifier semantic jglisse
2017-08-31 21:17 ` [PATCH 04/13] drm/amdgpu: " jglisse
2017-08-31 21:17 ` [PATCH 05/13] IB/umem: " jglisse
2017-08-31 21:17 ` [PATCH 06/13] IB/hfi1: " jglisse
2017-08-31 21:17 ` [PATCH 07/13] iommu/amd: " jglisse
2017-08-31 21:17 ` [PATCH 08/13] iommu/intel: " jglisse
2017-08-31 21:17 ` [PATCH 09/13] misc/mic/scif: " jglisse
2017-08-31 21:17 ` [PATCH 10/13] sgi-gru: " jglisse
2017-09-05 16:21 ` Dimitri Sivanich [this message]
2017-08-31 21:17 ` [PATCH 11/13] xen/gntdev: " jglisse
2017-08-31 21:17 ` [PATCH 12/13] KVM: update to new mmu_notifier semantic v2 jglisse
2017-08-31 21:17 ` [PATCH 13/13] mm/mmu_notifier: kill invalidate_page jglisse
2017-09-02 13:28 ` [PATCH 00/13] mmu_notifier kill invalidate_page callback v2 Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2017-08-29 23:54 [PATCH 00/13] mmu_notifier kill invalidate_page callback Jérôme Glisse
2017-08-29 23:54 ` [PATCH 10/13] sgi-gru: update to new mmu_notifier semantic Jérôme Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905162112.GC14176@hpe.com \
--to=sivanich@hpe.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).