From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team <kernel-team@lge.com>,
Ilya Dryomov <idryomov@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH 5/5] mm:swap: skip swapcache for swapin of synchronous device
Date: Tue, 12 Sep 2017 15:31:02 +0900 [thread overview]
Message-ID: <20170912063102.GA2068@bbox> (raw)
In-Reply-To: <20170912060456.GA703@jagdpanzerIV.localdomain>
On Tue, Sep 12, 2017 at 03:04:56PM +0900, Sergey Senozhatsky wrote:
> On (09/12/17 11:37), Minchan Kim wrote:
> > + } else {
> > + /* skip swapcache */
> > + page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->address);
>
> what if alloc_page_vma() fails?
Several modifications during development finally makes me remove the NULL check.
Thanks for catching it as well as style fix-up of other patch, Sergey.
next prev parent reply other threads:[~2017-09-12 6:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 2:37 [PATCH 1/5] zram: set BDI_CAP_STABLE_WRITES once Minchan Kim
2017-09-12 2:37 ` [PATCH 2/5] bdi: introduce BDI_CAP_SYNCHRONOUS_IO Minchan Kim
2017-09-12 2:37 ` [PATCH 3/5] mm:swap: introduce SWP_SYNCHRONOUS_IO Minchan Kim
2017-09-12 4:48 ` Sergey Senozhatsky
2017-09-12 2:37 ` [PATCH 4/5] mm:swap: respect page_cluster for readahead Minchan Kim
2017-09-12 5:23 ` Huang, Ying
2017-09-12 6:25 ` Minchan Kim
2017-09-12 6:44 ` Huang, Ying
2017-09-12 6:52 ` Minchan Kim
2017-09-12 7:29 ` Huang, Ying
2017-09-12 7:56 ` Minchan Kim
2017-09-12 8:07 ` Huang, Ying
2017-09-12 8:22 ` Minchan Kim
2017-09-12 8:32 ` Huang, Ying
2017-09-12 23:34 ` Minchan Kim
2017-09-13 0:55 ` Huang, Ying
2017-09-12 2:37 ` [PATCH 5/5] mm:swap: skip swapcache for swapin of synchronous device Minchan Kim
2017-09-12 6:04 ` Sergey Senozhatsky
2017-09-12 6:31 ` Minchan Kim [this message]
2017-09-12 20:22 ` kbuild test robot
2017-09-13 0:16 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912063102.GA2068@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=hughd@google.com \
--cc=idryomov@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ross.zwisler@linux.intel.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).