From: Alexandru Moise <00moses.alexander00@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, khandual@linux.vnet.ibm.com,
mhocko@suse.com, aarcange@redhat.com, minchan@kernel.org,
hillf.zj@alibaba-inc.com, shli@fb.com, rppt@linux.vnet.ibm.com,
kirill.shutemov@linux.intel.com, mgorman@techsingularity.net,
rientjes@google.com, riel@redhat.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm, hugetlb, soft_offline: save compound page order before page migration
Date: Tue, 12 Sep 2017 23:10:39 +0200 [thread overview]
Message-ID: <20170912211039.GA16850@gmail.com> (raw)
In-Reply-To: <20170912135448.341359676c6f8045f4a622f0@linux-foundation.org>
On Tue, Sep 12, 2017 at 01:54:48PM -0700, Andrew Morton wrote:
> On Tue, 12 Sep 2017 22:43:06 +0200 Alexandru Moise <00moses.alexander00@gmail.com> wrote:
>
> > This fixes a bug in madvise() where if you'd try to soft offline a
> > hugepage via madvise(), while walking the address range you'd end up,
> > using the wrong page offset due to attempting to get the compound
> > order of a former but presently not compound page, due to dissolving
> > the huge page (since c3114a8).
>
> What are the user visible effects of the bug? The wrong page is
> offlined? No offlining occurs?
I end up with all my free pages getting offlined. Except 1.
../Alex
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-12 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 20:43 [PATCH] mm, hugetlb, soft_offline: save compound page order before page migration Alexandru Moise
2017-09-12 20:54 ` Andrew Morton
2017-09-12 20:58 ` Andrew Morton
2017-09-12 21:12 ` Alexandru Moise
2017-09-12 21:10 ` Alexandru Moise [this message]
2017-09-13 0:13 ` Naoya Horiguchi
2017-09-13 8:32 ` Alexandru Moise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912211039.GA16850@gmail.com \
--to=00moses.alexander00@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).