From: Jan Kara <jack@suse.cz>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, hannes@cmpxchg.org, clm@fb.com, jack@suse.cz
Subject: Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in laptop mode
Date: Wed, 20 Sep 2017 16:35:05 +0200 [thread overview]
Message-ID: <20170920143505.GD11106@quack2.suse.cz> (raw)
In-Reply-To: <1505850787-18311-4-git-send-email-axboe@kernel.dk>
On Tue 19-09-17 13:53:04, Jens Axboe wrote:
> Laptop mode really wants to writeback the number of dirty
> pages and inodes. Instead of calculating this in the caller,
> just pass in 0 and let wakeup_flusher_threads() handle it.
>
> Use the new wakeup_flusher_threads_bdi() instead of rolling
> our own.
>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
...
> - rcu_read_lock();
> - list_for_each_entry_rcu(wb, &q->backing_dev_info->wb_list, bdi_node)
> - if (wb_has_dirty_io(wb))
> - wb_start_writeback(wb, nr_pages, true,
> - WB_REASON_LAPTOP_TIMER);
> - rcu_read_unlock();
> + wakeup_flusher_threads_bdi(q->backing_dev_info, 0,
> + WB_REASON_LAPTOP_TIMER);
> }
So this slightly changes the semantics since previously we were doing
range_cyclic writeback and now we don't. I don't think this matters in
practice but please mention that in the changelog. With that you can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-20 14:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 19:53 [PATCH 0/6] More graceful flusher thread memory reclaim wakeup Jens Axboe
2017-09-19 19:53 ` [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Jens Axboe
2017-09-19 20:05 ` Johannes Weiner
2017-09-20 14:17 ` Jan Kara
2017-09-20 15:18 ` Jens Axboe
2017-09-19 19:53 ` [PATCH 2/6] fs-writeback: provide a wakeup_flusher_threads_bdi() Jens Axboe
2017-09-19 20:05 ` Johannes Weiner
2017-09-20 14:19 ` Jan Kara
2017-09-19 19:53 ` [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in laptop mode Jens Axboe
2017-09-19 20:06 ` Johannes Weiner
2017-09-20 14:35 ` Jan Kara [this message]
2017-09-20 15:19 ` Jens Axboe
2017-09-19 19:53 ` [PATCH 4/6] fs-writeback: make wb_start_writeback() static Jens Axboe
2017-09-19 20:07 ` Johannes Weiner
2017-09-20 14:35 ` Jan Kara
2017-09-19 19:53 ` [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location Jens Axboe
2017-09-19 20:07 ` Johannes Weiner
2017-09-20 14:41 ` Jan Kara
2017-09-20 15:05 ` Jens Axboe
2017-09-20 15:36 ` Jan Kara
2017-09-20 15:40 ` Jens Axboe
2017-09-19 19:53 ` [PATCH 6/6] fs-writeback: only allow one inflight and pending !nr_pages flush Jens Axboe
2017-09-19 20:18 ` Johannes Weiner
2017-09-19 20:39 ` Jens Axboe
2017-09-20 1:57 ` Jens Axboe
2017-09-20 3:10 ` Amir Goldstein
2017-09-20 4:13 ` Jens Axboe
2017-09-20 6:05 ` Amir Goldstein
2017-09-20 12:35 ` Jens Axboe
2017-09-20 14:43 ` Jan Kara
2017-09-20 19:29 ` [PATCH 0/6] More graceful flusher thread memory reclaim wakeup John Stoffel
2017-09-20 19:32 ` Jens Axboe
2017-09-20 23:11 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920143505.GD11106@quack2.suse.cz \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).