From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f71.google.com (mail-pg0-f71.google.com [74.125.83.71]) by kanga.kvack.org (Postfix) with ESMTP id 901EC6B0038 for ; Thu, 21 Sep 2017 10:59:33 -0400 (EDT) Received: by mail-pg0-f71.google.com with SMTP id p5so12049413pgn.7 for ; Thu, 21 Sep 2017 07:59:33 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [65.50.211.133]) by mx.google.com with ESMTPS id m197si1128071pga.97.2017.09.21.07.59.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 07:59:32 -0700 (PDT) Date: Thu, 21 Sep 2017 07:59:30 -0700 From: Christoph Hellwig Subject: Re: [PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback in laptop mode Message-ID: <20170921145929.GD8839@infradead.org> References: <1505921582-26709-1-git-send-email-axboe@kernel.dk> <1505921582-26709-5-git-send-email-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505921582-26709-5-git-send-email-axboe@kernel.dk> Sender: owner-linux-mm@kvack.org List-ID: To: Jens Axboe Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, clm@fb.com, jack@suse.cz On Wed, Sep 20, 2017 at 09:32:59AM -0600, Jens Axboe wrote: > Laptop mode really wants to writeback the number of dirty > pages and inodes. Instead of calculating this in the caller, > just pass in 0 and let wakeup_flusher_threads() handle it. > > Use the new wakeup_flusher_threads_bdi() instead of rolling > our own. This changes the writeback to not be range cyclic, > but that should not matter for laptop mode flush-all > semantics. Looks good, Reviewed-by: Christoph Hellwig While we're at sorting out the laptop_mode_wb_timer mess: can we move initializing and deleting it from the block code to the backing-dev code given that it now doesn't assume anything about block devices any more? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org