From: "Du, Changbin" <changbin.du@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: changbin.du@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: update comments for struct page.mapping
Date: Wed, 27 Sep 2017 11:59:53 +0800 [thread overview]
Message-ID: <20170927035953.GA13117@intel.com> (raw)
In-Reply-To: <20170926163027.12836f5006745fcf6e59ad24@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On Tue, Sep 26, 2017 at 04:30:27PM -0700, Andrew Morton wrote:
> On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@intel.com wrote:
>
> > From: Changbin Du <changbin.du@intel.com>
> >
> > The struct page.mapping can NULL or points to one object of type
> > address_space, anon_vma or KSM private structure.
> >
> > ...
> >
> > --- a/include/linux/mm_types.h
> > +++ b/include/linux/mm_types.h
> > @@ -47,8 +47,8 @@ struct page {
> > * inode address_space, or NULL.
> > * If page mapped as anonymous
> > * memory, low bit is set, and
> > - * it points to anon_vma object:
> > - * see PAGE_MAPPING_ANON below.
> > + * it points to anon_vma object
> > + * or KSM private structure.
> > */
> > void *s_mem; /* slab first object */
> > atomic_t compound_mapcount; /* first tail page */
>
> Why did you remove the (useful) reference to PAGE_MAPPING_ANON?
There are two flags now, let me add them back. thanks.
--
Thanks,
Changbin Du
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2017-09-27 4:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 7:14 [PATCH] mm: update comments for struct page.mapping changbin.du
2017-09-26 23:30 ` Andrew Morton
2017-09-27 3:59 ` Du, Changbin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927035953.GA13117@intel.com \
--to=changbin.du@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).