* [PATCH] mm: update comments for struct page.mapping
@ 2017-09-26 7:14 changbin.du
2017-09-26 23:30 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: changbin.du @ 2017-09-26 7:14 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, linux-mm, Changbin Du
From: Changbin Du <changbin.du@intel.com>
The struct page.mapping can NULL or points to one object of type
address_space, anon_vma or KSM private structure.
Signed-off-by: Changbin Du <changbin.du@intel.com>
---
include/linux/mm_types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 46f4ecf5..8dd6cb3 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -47,8 +47,8 @@ struct page {
* inode address_space, or NULL.
* If page mapped as anonymous
* memory, low bit is set, and
- * it points to anon_vma object:
- * see PAGE_MAPPING_ANON below.
+ * it points to anon_vma object
+ * or KSM private structure.
*/
void *s_mem; /* slab first object */
atomic_t compound_mapcount; /* first tail page */
--
2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: update comments for struct page.mapping
2017-09-26 7:14 [PATCH] mm: update comments for struct page.mapping changbin.du
@ 2017-09-26 23:30 ` Andrew Morton
2017-09-27 3:59 ` Du, Changbin
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2017-09-26 23:30 UTC (permalink / raw)
To: changbin.du; +Cc: linux-kernel, linux-mm
On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> The struct page.mapping can NULL or points to one object of type
> address_space, anon_vma or KSM private structure.
>
> ...
>
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -47,8 +47,8 @@ struct page {
> * inode address_space, or NULL.
> * If page mapped as anonymous
> * memory, low bit is set, and
> - * it points to anon_vma object:
> - * see PAGE_MAPPING_ANON below.
> + * it points to anon_vma object
> + * or KSM private structure.
> */
> void *s_mem; /* slab first object */
> atomic_t compound_mapcount; /* first tail page */
Why did you remove the (useful) reference to PAGE_MAPPING_ANON?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: update comments for struct page.mapping
2017-09-26 23:30 ` Andrew Morton
@ 2017-09-27 3:59 ` Du, Changbin
0 siblings, 0 replies; 3+ messages in thread
From: Du, Changbin @ 2017-09-27 3:59 UTC (permalink / raw)
To: Andrew Morton; +Cc: changbin.du, linux-kernel, linux-mm
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On Tue, Sep 26, 2017 at 04:30:27PM -0700, Andrew Morton wrote:
> On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@intel.com wrote:
>
> > From: Changbin Du <changbin.du@intel.com>
> >
> > The struct page.mapping can NULL or points to one object of type
> > address_space, anon_vma or KSM private structure.
> >
> > ...
> >
> > --- a/include/linux/mm_types.h
> > +++ b/include/linux/mm_types.h
> > @@ -47,8 +47,8 @@ struct page {
> > * inode address_space, or NULL.
> > * If page mapped as anonymous
> > * memory, low bit is set, and
> > - * it points to anon_vma object:
> > - * see PAGE_MAPPING_ANON below.
> > + * it points to anon_vma object
> > + * or KSM private structure.
> > */
> > void *s_mem; /* slab first object */
> > atomic_t compound_mapcount; /* first tail page */
>
> Why did you remove the (useful) reference to PAGE_MAPPING_ANON?
There are two flags now, let me add them back. thanks.
--
Thanks,
Changbin Du
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-27 4:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-26 7:14 [PATCH] mm: update comments for struct page.mapping changbin.du
2017-09-26 23:30 ` Andrew Morton
2017-09-27 3:59 ` Du, Changbin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).