From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>, Shaohua Li <shli@kernel.org>,
Hugh Dickins <hughd@google.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Tim Chen <tim.c.chen@intel.com>,
Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH] mm, swap: Make VMA based swap readahead configurable
Date: Wed, 27 Sep 2017 23:10:08 +0900 [thread overview]
Message-ID: <20170927141008.GA1278@bgram> (raw)
In-Reply-To: <20170927135034.yatxlhvunawzmcar@dhcp22.suse.cz>
On Wed, Sep 27, 2017 at 03:50:34PM +0200, Michal Hocko wrote:
> On Wed 27-09-17 22:41:17, Minchan Kim wrote:
> > On Wed, Sep 27, 2017 at 03:22:41PM +0200, Michal Hocko wrote:
> [...]
> > > simply cannot disable swap readahead when page-cluster is 0?
> >
> > That's was what I want really but Huang want to use two readahead
> > algorithms in parallel so he wanted to keep two separated disable
> > knobs.
>
> If it breaks existing and documented behavior then it is a clear
> regression and it should be fixed. I do not see why this should be
> disputable at all.
Indeed but Huang doesn't think so. He has thought it's not a regression.
Frankly speaking, I'm really bored of discussing with it.
https://marc.info/?l=linux-mm&m=150526413319763&w=2
So I passed the decision to Andrew.
http://lkml.kernel.org/r/<20170913014019.GB29422@bbox>
The config option idea is compromise approach although I don't like it
and still believe it's simple clear *regression* so 0 page-cluster
should keep the swap readahead disabled.
>
> Working around an issue with a config option sounds like the wrong way
> to go because those who cannot do that unconditionally would still see a
> regression.
I absolutely agree but as I said, the discussion was not productive
even though I did best effort to persuade. That's all for my side as
contributor/reviewer. Decision is up to maintainer. ;-)
Thanks for the opinion, Michal.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-27 14:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 1:33 [PATCH] mm, swap: Make VMA based swap readahead configurable Huang, Ying
2017-09-25 5:41 ` Minchan Kim
2017-09-25 5:54 ` Huang, Ying
2017-09-25 6:17 ` Minchan Kim
2017-09-25 6:24 ` Huang, Ying
2017-09-25 6:30 ` Minchan Kim
2017-09-26 13:21 ` Michal Hocko
2017-09-27 1:36 ` Huang, Ying
2017-09-27 5:04 ` Minchan Kim
2017-09-27 7:48 ` Michal Hocko
2017-09-27 8:04 ` Minchan Kim
2017-09-27 8:35 ` Michal Hocko
2017-09-27 13:15 ` Minchan Kim
2017-09-27 13:22 ` Michal Hocko
2017-09-27 13:41 ` Minchan Kim
2017-09-27 13:50 ` Michal Hocko
2017-09-27 14:10 ` Minchan Kim [this message]
2017-09-27 14:17 ` Michal Hocko
2017-09-28 1:02 ` Huang, Ying
2017-10-02 7:23 ` Michal Hocko
2017-10-02 15:45 ` Dave Hansen
2017-10-02 21:49 ` Andrew Morton
2017-10-06 12:28 ` huang ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927141008.GA1278@bgram \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).