From: Jan Kara <jack@suse.cz>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 14/15] mm: Remove nr_pages argument from pagevec_lookup_{,range}_tag()
Date: Tue, 3 Oct 2017 11:07:59 +0200 [thread overview]
Message-ID: <20171003090759.GH11879@quack2.suse.cz> (raw)
In-Reply-To: <d86aeb9d-fc2b-c041-ae24-d8ccf06325e7@oracle.com>
On Fri 29-09-17 17:46:24, Daniel Jordan wrote:
> On 09/27/2017 12:03 PM, Jan Kara wrote:
> >All users of pagevec_lookup() and pagevec_lookup_range() now pass
> >PAGEVEC_SIZE as a desired number of pages. Just drop the argument.
> >
> >Signed-off-by: Jan Kara <jack@suse.cz>
> >---
> > fs/btrfs/extent_io.c | 6 +++---
>
> There's one place that got missed in fs/ceph/addr.c:
Ah, that's probably from a rebase I did. Thanks for catching this!
Honza
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 87789c477381..ee68b3db6729 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1161,8 +1161,7 @@ static int ceph_writepages_start(struct address_space
> *mapping,
> index = 0;
> while ((index <= end) &&
> (nr = pagevec_lookup_tag(&pvec, mapping,
> &index,
> - PAGECACHE_TAG_WRITEBACK,
> - PAGEVEC_SIZE))) {
> + PAGECACHE_TAG_WRITEBACK))) {
> for (i = 0; i < nr; i++) {
> page = pvec.pages[i];
> if (page_snap_context(page) !=
> snapc)
>
>
> Daniel
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-03 9:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 16:03 [PATCH 0/15 v2] Ranged pagevec tagged lookup Jan Kara
2017-09-27 16:03 ` [PATCH 01/15] mm: Implement find_get_pages_range_tag() Jan Kara
2017-09-27 16:03 ` [PATCH 02/15] btrfs: Use pagevec_lookup_range_tag() Jan Kara
2017-09-27 16:03 ` [PATCH 03/15] ceph: " Jan Kara
2017-09-29 1:20 ` Yan, Zheng
2017-09-27 16:03 ` [PATCH 04/15] ext4: " Jan Kara
2017-09-27 16:03 ` [PATCH 05/15] f2fs: " Jan Kara
2017-09-27 16:03 ` [PATCH 06/15] f2fs: Simplify page iteration loops Jan Kara
2017-09-27 16:03 ` [PATCH 07/15] f2fs: Use find_get_pages_tag() for looking up single page Jan Kara
2017-09-27 16:03 ` [PATCH 08/15] gfs2: Use pagevec_lookup_range_tag() Jan Kara
2017-09-27 16:03 ` [PATCH 09/15] nilfs2: " Jan Kara
2017-09-28 1:40 ` Ryusuke Konishi
2017-09-27 16:03 ` [PATCH 10/15] mm: Use pagevec_lookup_range_tag() in __filemap_fdatawait_range() Jan Kara
2017-09-27 22:19 ` Dave Chinner
2017-10-03 8:38 ` Jan Kara
2017-09-27 16:03 ` [PATCH 11/15] mm: Use pagevec_lookup_range_tag() in write_cache_pages() Jan Kara
2017-09-27 16:03 ` [PATCH 12/15] mm: Add variant of pagevec_lookup_range_tag() taking number of pages Jan Kara
2017-09-29 21:45 ` Daniel Jordan
2017-10-03 8:51 ` Jan Kara
2017-09-27 16:03 ` [PATCH 13/15] ceph: Use pagevec_lookup_range_nr_tag() Jan Kara
2017-09-27 16:03 ` [PATCH 14/15] mm: Remove nr_pages argument from pagevec_lookup_{,range}_tag() Jan Kara
2017-09-29 21:46 ` Daniel Jordan
2017-10-03 9:07 ` Jan Kara [this message]
2017-09-27 16:03 ` [PATCH 15/15] afs: Use find_get_pages_range_tag() Jan Kara
2017-09-29 21:46 ` Daniel Jordan
2017-10-03 12:03 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2017-09-14 13:18 [PATCH 0/15 v1] Ranged pagevec tagged lookup Jan Kara
2017-09-14 13:18 ` [PATCH 14/15] mm: Remove nr_pages argument from pagevec_lookup_{,range}_tag() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003090759.GH11879@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).