From: Jerome Glisse <jglisse@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-mm@kvack.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hmm: remove redundant variable align_end
Date: Tue, 17 Oct 2017 12:31:49 -0400 [thread overview]
Message-ID: <20171017163148.GC2933@redhat.com> (raw)
In-Reply-To: <20171017143837.23207-1-colin.king@canonical.com>
On Tue, Oct 17, 2017 at 03:38:37PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable align_end is assigned a value but it is never read, so
> the variable is redundant and can be removed. Cleans up the clang
> warning: Value stored to 'align_end' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jerome Glisse <jglisse@redhat.com>
> ---
> mm/hmm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index a88a847bccba..ea19742a5d60 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -803,11 +803,10 @@ static RADIX_TREE(hmm_devmem_radix, GFP_KERNEL);
>
> static void hmm_devmem_radix_release(struct resource *resource)
> {
> - resource_size_t key, align_start, align_size, align_end;
> + resource_size_t key, align_start, align_size;
>
> align_start = resource->start & ~(PA_SECTION_SIZE - 1);
> align_size = ALIGN(resource_size(resource), PA_SECTION_SIZE);
> - align_end = align_start + align_size - 1;
>
> mutex_lock(&hmm_devmem_lock);
> for (key = resource->start;
> --
> 2.14.1
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-10-17 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:38 [PATCH] mm/hmm: remove redundant variable align_end Colin King
2017-10-17 16:31 ` Jerome Glisse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017163148.GC2933@redhat.com \
--to=jglisse@redhat.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).