From: Balbir Singh <bsingharora@gmail.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Minchan Kim <minchan@kernel.org>,
Yisheng Xie <xieyisheng1@huawei.com>,
Ingo Molnar <mingo@kernel.org>, Greg Thelen <gthelen@google.com>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: mlock: remove lru_add_drain_all()
Date: Thu, 19 Oct 2017 14:18:59 +1100 [thread overview]
Message-ID: <20171019141859.4c17f813@MiWiFi-R3-srv> (raw)
In-Reply-To: <20171018231730.42754-1-shakeelb@google.com>
On Wed, 18 Oct 2017 16:17:30 -0700
Shakeel Butt <shakeelb@google.com> wrote:
> Recently we have observed high latency in mlock() in our generic
> library and noticed that users have started using tmpfs files even
> without swap and the latency was due to expensive remote LRU cache
> draining.
>
> Is lru_add_drain_all() required by mlock()? The answer is no and the
> reason it is still in mlock() is to rapidly move mlocked pages to
> unevictable LRU. Without lru_add_drain_all() the mlocked pages which
> were on pagevec at mlock() time will be moved to evictable LRUs but
> will eventually be moved back to unevictable LRU by reclaim. So, we
> can safely remove lru_add_drain_all() from mlock(). Also there is no
> need for local lru_add_drain() as it will be called deep inside
> __mm_populate() (in follow_page_pte()).
>
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> ---
Does this perturb statistics around LRU pages in cgroups and meminfo
about where the pages actually belong?
Balbir Singh.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-19 3:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 23:17 [PATCH] mm: mlock: remove lru_add_drain_all() Shakeel Butt
2017-10-19 3:18 ` Balbir Singh [this message]
2017-10-19 20:12 ` Shakeel Butt
2017-10-19 6:24 ` Anshuman Khandual
2017-10-19 19:19 ` Shakeel Butt
2017-10-19 10:18 ` Kirill A. Shutemov
2017-10-19 19:19 ` Shakeel Butt
2017-10-19 12:32 ` Michal Hocko
2017-10-19 19:19 ` Shakeel Butt
2017-10-19 19:35 ` Michal Hocko
2017-10-19 19:46 ` Shakeel Butt
2017-10-19 20:13 ` Michal Hocko
2017-10-19 20:14 ` Shakeel Butt
2017-10-19 20:53 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019141859.4c17f813@MiWiFi-R3-srv \
--to=bsingharora@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).