From: Mike Kravetz <mike.kravetz@oracle.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Michal Hocko <mhocko@kernel.org>,
Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: [PATCH 0/1] mm:hugetlbfs: Fix hwpoison reserve accounting
Date: Thu, 19 Oct 2017 16:00:06 -0700 [thread overview]
Message-ID: <20171019230007.17043-1-mike.kravetz@oracle.com> (raw)
The routine hugetlbfs_error_remove_page() incorrectly calls
hugetlb_fix_reserve_counts which will result in bad (negative)
reserved huge page counts. The following patch addresses this
issue.
A follow up question/issue:
When a hugetlbfs page is poisoned, it appears as an 'in use'
huge page via all the external user visible metrics. Even the
in internal counters think this is simply an 'in use' huge page.
This usually is not an issue. However, it may be confusing if
someone adjusts the total number of huge pages. For example,
if after poisoning a huge page I set the total number of huge
pages to zero, the poisoned page will be counted as 'surplus'.
I was thinking about keeping at least a bad page count (if not
a list) to avoid user confusion. It may be overkill as I have
not given too much thought to this issue. Anyone else have
thoughts here?
Mike Kravetz (1):
mm:hugetlbfs: Fix hwpoison reserve accounting
fs/hugetlbfs/inode.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.13.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-10-19 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 23:00 Mike Kravetz [this message]
2017-10-19 23:00 ` [PATCH 1/1] mm:hugetlbfs: Fix hwpoison reserve accounting Mike Kravetz
2017-10-20 2:30 ` Naoya Horiguchi
2017-10-20 17:49 ` Mike Kravetz
2017-10-23 7:32 ` Naoya Horiguchi
2017-10-23 18:20 ` Mike Kravetz
2017-10-24 0:46 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019230007.17043-1-mike.kravetz@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).