From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 232B66B0253 for ; Sat, 21 Oct 2017 04:11:42 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id m72so5595564wmc.0 for ; Sat, 21 Oct 2017 01:11:42 -0700 (PDT) Received: from newverein.lst.de (verein.lst.de. [213.95.11.211]) by mx.google.com with ESMTPS id j130si428492wmd.165.2017.10.21.01.11.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Oct 2017 01:11:41 -0700 (PDT) Date: Sat, 21 Oct 2017 10:11:40 +0200 From: Christoph Hellwig Subject: Re: [PATCH v3 12/13] dax: handle truncate of dma-busy pages Message-ID: <20171021081140.GA21101@lst.de> References: <150846713528.24336.4459262264611579791.stgit@dwillia2-desk3.amr.corp.intel.com> <150846720244.24336.16885325309403883980.stgit@dwillia2-desk3.amr.corp.intel.com> <1508504726.5572.41.camel@kernel.org> <20171020163221.GB26320@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Dan Williams Cc: Christoph Hellwig , Jeff Layton , Andrew Morton , Jan Kara , Matthew Wilcox , Dave Hansen , Dave Chinner , "linux-kernel@vger.kernel.org" , "J. Bruce Fields" , Linux MM , Jeff Moyer , Alexander Viro , linux-fsdevel , "Darrick J. Wong" , Ross Zwisler , linux-xfs@vger.kernel.org, "linux-nvdimm@lists.01.org" On Fri, Oct 20, 2017 at 10:27:22AM -0700, Dan Williams wrote: > I'll take a look at hooking this up through a page-idle callback. Can > I get some breadcrumbs to grep for from XFS folks on how to set/clear > the busy state of extents? As Brian pointed out it's the xfs_extent_busy.c file (and I pointed out the same in a reply to the previous series). Be careful because you'll need a refcount or flags now that there are different busy reasons. I still think we'd be better off just blocking on an elevated page count directly in truncate as that will avoid all the busy list manipulations. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org