From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f71.google.com (mail-pg0-f71.google.com [74.125.83.71]) by kanga.kvack.org (Postfix) with ESMTP id 7F43A6B0253 for ; Tue, 14 Nov 2017 08:54:01 -0500 (EST) Received: by mail-pg0-f71.google.com with SMTP id s75so20315346pgs.12 for ; Tue, 14 Nov 2017 05:54:01 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id z1sor4447244pgp.396.2017.11.14.05.54.00 for (Google Transport Security); Tue, 14 Nov 2017 05:54:00 -0800 (PST) From: Michal Hocko Subject: [PATCH] mm: drop hotplug lock from lru_add_drain_all Date: Tue, 14 Nov 2017 14:53:48 +0100 Message-Id: <20171114135348.28704-1-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Tejun Heo , Peter Zijlstra , Thomas Gleixner , Johannes Weiner , Mel Gorman , linux-mm@kvack.org, LKML , Michal Hocko From: Michal Hocko Pulling cpu hotplug locks inside the mm core function like lru_add_drain_all just asks for problems and the recent lockdep splat [1] just proves this. While the usage in that particular case might be wrong we should prevent from locking as lru_add_drain_all is used at many places. It seems that this is not all that hard to achieve actually. We have done the same thing for drain_all_pages which is analogous by a459eeb7b852 ("mm, page_alloc: do not depend on cpu hotplug locks inside the allocator"). All we have to care about is to handle - the work item might be executed on a different cpu in worker from unbound pool so it doesn't run on pinned on the cpu - we have to make sure that we do not race with page_alloc_cpu_dead calling lru_add_drain_cpu the first part is already handled because the worker calls lru_add_drain which disables preemption when calling lru_add_drain_cpu on the local cpu it is draining. The later is true because page_alloc_cpu_dead is called on the controlling CPU after the hotplugged CPU vanished completely. [1] http://lkml.kernel.org/r/089e0825eec8955c1f055c83d476@google.com Signed-off-by: Michal Hocko --- Hi, this has been posted as 2 patch series [1] previously. It turned out that the first patch was simply broken and the second one could be simplified because the irq disabling is just pointless. There were no other objections so I am resending this patch which should remove quite a large space of potential lockups as lru_add_drain_all is used at many places so removing the hoptlug locking is a good thing in general. Can we have this merged or there are still some objections? [1] http://lkml.kernel.org/r/20171102093613.3616-1-mhocko@kernel.org include/linux/swap.h | 1 - mm/memory_hotplug.c | 2 +- mm/swap.c | 9 +-------- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 84255b3da7c1..cfc200673e13 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -331,7 +331,6 @@ extern void mark_page_accessed(struct page *); extern void lru_add_drain(void); extern void lru_add_drain_cpu(int cpu); extern void lru_add_drain_all(void); -extern void lru_add_drain_all_cpuslocked(void); extern void rotate_reclaimable_page(struct page *page); extern void deactivate_file_page(struct page *page); extern void mark_page_lazyfree(struct page *page); diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 832a042134f8..c9f6b418be79 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1641,7 +1641,7 @@ static int __ref __offline_pages(unsigned long start_pfn, goto failed_removal; cond_resched(); - lru_add_drain_all_cpuslocked(); + lru_add_drain_all(); drain_all_pages(zone); pfn = scan_movable_pages(start_pfn, end_pfn); diff --git a/mm/swap.c b/mm/swap.c index 381e0fe9efbf..8bfdcab9f83e 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -688,7 +688,7 @@ static void lru_add_drain_per_cpu(struct work_struct *dummy) static DEFINE_PER_CPU(struct work_struct, lru_add_drain_work); -void lru_add_drain_all_cpuslocked(void) +void lru_add_drain_all(void) { static DEFINE_MUTEX(lock); static struct cpumask has_work; @@ -724,13 +724,6 @@ void lru_add_drain_all_cpuslocked(void) mutex_unlock(&lock); } -void lru_add_drain_all(void) -{ - get_online_cpus(); - lru_add_drain_all_cpuslocked(); - put_online_cpus(); -} - /** * release_pages - batched put_page() * @pages: array of pages to release -- 2.15.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org