From: Andrew Morton <akpm@linux-foundation.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: kernel-team@fb.com, linux-mm@kvack.org, Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] mm: use sc->priority for slab shrink targets
Date: Wed, 15 Nov 2017 15:48:26 -0800 [thread overview]
Message-ID: <20171115154826.45d70959f630ac7508d8d36e@linux-foundation.org> (raw)
In-Reply-To: <1510766070-4772-1-git-send-email-josef@toxicpanda.com>
On Wed, 15 Nov 2017 12:14:30 -0500 Josef Bacik <josef@toxicpanda.com> wrote:
> Previously we were using the ratio of the number of lru pages scanned to
> the number of eligible lru pages to determine the number of slab objects
> to scan. The problem with this is that these two things have nothing to
> do with each other, so in slab heavy work loads where there is little to
> no page cache we can end up with the pages scanned being a very low
> number. This means that we reclaim next to no slab pages and waste a
> lot of time reclaiming small amounts of space.
>
> ...
>
> Andrew, I noticed you hadn't picked this up yet, so I rebased it on the latest
> linus and updated the ack's, it should be good to go.
I dropped a previous version of this on Oct 3 due to runtime failures
(I think). What were those and how does this patch fix them (if it
does?)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-15 23:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 17:14 [PATCH] mm: use sc->priority for slab shrink targets Josef Bacik
2017-11-15 23:48 ` Andrew Morton [this message]
2017-11-16 0:52 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115154826.45d70959f630ac7508d8d36e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jbacik@fb.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).