* [PATCH v2] mm: filemap: remove include of hardirq.h
@ 2017-11-06 16:21 Yang Shi
2017-11-17 17:58 ` Yang Shi
0 siblings, 1 reply; 3+ messages in thread
From: Yang Shi @ 2017-11-06 16:21 UTC (permalink / raw)
To: mhocko, akpm, willy; +Cc: Yang Shi, linux-mm, linux-kernel
in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
doesn't use in_atomic() directly at all, so it sounds unnecessary to
include hardirq.h.
Signed-off-by: Yang Shi <yang.s@alibaba-inc.com>
---
v1 --> v2:
* Removed the wrong message about kernel size change
mm/filemap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 594d73f..57238f4 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -31,7 +31,6 @@
#include <linux/blkdev.h>
#include <linux/security.h>
#include <linux/cpuset.h>
-#include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
#include <linux/hugetlb.h>
#include <linux/memcontrol.h>
#include <linux/cleancache.h>
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm: filemap: remove include of hardirq.h
2017-11-06 16:21 [PATCH v2] mm: filemap: remove include of hardirq.h Yang Shi
@ 2017-11-17 17:58 ` Yang Shi
2017-11-17 18:06 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Yang Shi @ 2017-11-17 17:58 UTC (permalink / raw)
To: mhocko, akpm, willy; +Cc: linux-mm, linux-kernel
Hi folks,
Any comment on this patch? The quick build test passed on the latest
Linus's tree.
Thanks,
Yang
On 11/6/17 8:21 AM, Yang Shi wrote:
> in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
> doesn't use in_atomic() directly at all, so it sounds unnecessary to
> include hardirq.h.
>
> Signed-off-by: Yang Shi <yang.s@alibaba-inc.com>
> ---
> v1 --> v2:
> * Removed the wrong message about kernel size change
>
> mm/filemap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 594d73f..57238f4 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -31,7 +31,6 @@
> #include <linux/blkdev.h>
> #include <linux/security.h>
> #include <linux/cpuset.h>
> -#include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
> #include <linux/hugetlb.h>
> #include <linux/memcontrol.h>
> #include <linux/cleancache.h>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mm: filemap: remove include of hardirq.h
2017-11-17 17:58 ` Yang Shi
@ 2017-11-17 18:06 ` Matthew Wilcox
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2017-11-17 18:06 UTC (permalink / raw)
To: Yang Shi; +Cc: mhocko, akpm, linux-mm, linux-kernel
On Sat, Nov 18, 2017 at 01:58:15AM +0800, Yang Shi wrote:
> Hi folks,
>
> Any comment on this patch? The quick build test passed on the latest Linus's
> tree.
Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-17 18:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 16:21 [PATCH v2] mm: filemap: remove include of hardirq.h Yang Shi
2017-11-17 17:58 ` Yang Shi
2017-11-17 18:06 ` Matthew Wilcox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).