From: Johannes Weiner <hannes@cmpxchg.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>,
Michal Nazarewicz <mina86@mina86.com>,
Michal Hocko <mhocko@suse.com>,
Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] mm/cma: fix alloc_contig_range ret code/potential leak
Date: Mon, 27 Nov 2017 16:59:06 +0000 [thread overview]
Message-ID: <20171127165906.GA16092@cmpxchg.org> (raw)
In-Reply-To: <20171122185214.25285-1-mike.kravetz@oracle.com>
On Wed, Nov 22, 2017 at 10:52:14AM -0800, Mike Kravetz wrote:
> If the call __alloc_contig_migrate_range() in alloc_contig_range
> returns -EBUSY, processing continues so that test_pages_isolated()
> is called where there is a tracepoint to identify the busy pages.
> However, it is possible for busy pages to become available between
> the calls to these two routines. In this case, the range of pages
> may be allocated. Unfortunately, the original return code (ret
> == -EBUSY) is still set and returned to the caller. Therefore,
> the caller believes the pages were not allocated and they are leaked.
>
> Update comment to indicate that allocation is still possible even if
> __alloc_contig_migrate_range returns -EBUSY. Also, clear return code
> in this case so that it is not accidentally used or returned to caller.
>
> Fixes: 8ef5849fa8a2 ("mm/cma: always check which page caused allocation failure")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-27 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 19:39 [PATCH 0/1] mm/cma: fix alloc_contig_range ret code/potential leak Mike Kravetz
2017-11-20 19:39 ` [PATCH 1/1] " Mike Kravetz
2017-11-21 7:53 ` Vlastimil Babka
2017-11-21 13:06 ` Michal Hocko
2017-11-21 13:04 ` Michal Hocko
2017-11-21 14:20 ` Michal Nazarewicz
2017-11-22 12:00 ` Johannes Weiner
2017-11-22 17:46 ` Mike Kravetz
2017-11-22 18:52 ` [PATCH v2] " Mike Kravetz
2017-11-23 8:05 ` Vlastimil Babka
2017-11-23 9:19 ` Michal Hocko
2017-11-27 16:59 ` Johannes Weiner [this message]
2017-11-29 5:38 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127165906.GA16092@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=mina86@mina86.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).